linux-kernel - Re: [PATCH] afs: Fix missing/incorrect unlocking of RCU read lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAB9dFduVrz=-bb8YSmJq4Ec7Nr3K49ubznoTa0sdCyZzkddyRA@mail.gmail.com>
Date: Wed, 17 Jan 2024 12:51:44 -0400
From: Marc Dionne <marc.dionne@...istor.com>
To: David Howells <dhowells@...hat.com>
Cc: linux-afs@...ts.infradead.org, linux-fsdevel@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] afs: Fix missing/incorrect unlocking of RCU read lock

On Wed, Jan 17, 2024 at 12:21 PM David Howells <dhowells@...hat.com> wrote:
>
> David Howells <dhowells@...hat.com> wrote:
>
> > In afs_proc_addr_prefs_show(), we need to unlock the RCU read lock in both
> > places before returning (and not lock it again).
> >
> > Fixes: f94f70d39cc2 ("afs: Provide a way to configure address priorities")
> > Reported-by: Marc Dionne <marc.dionne@...istor.com>
>
> Actually:
>
> Reported-by: kernel test robot <oliver.sang@...el.com>
> Closes: https://lore.kernel.org/oe-lkp/202401172243.cd53d5f6-oliver.sang@intel.com
> > Signed-off-by: David Howells <dhowells@...hat.com>
> > cc: linux-afs@...ts.infradead.org
> > cc: linux-fsdevel@...r.kernel.org
>
> David

The fix looks fine.

Reviewed-by: Marc Dionne <marc.dionne@...istor.com>

Marc