linux-kernel - Re: [PATCH bpf-next v5 3/3] selftests/bpf: Skip callback tests if jit is disabled in test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPhsuW6mWoQQ1M-uPE_i+RWv=t5GaVqUDAObWgpEC-PCYSbwHQ@mail.gmail.com>
Date: Wed, 17 Jan 2024 09:20:29 -0800
From: Song Liu <song@...nel.org>
To: Tiezhu Yang <yangtiezhu@...ngson.cn>
Cc: Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, 
	Andrii Nakryiko <andrii@...nel.org>, Eduard Zingerman <eddyz87@...il.com>, 
	John Fastabend <john.fastabend@...il.com>, Jiri Olsa <jolsa@...nel.org>, 
	Hou Tao <houtao@...weicloud.com>, bpf@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH bpf-next v5 3/3] selftests/bpf: Skip callback tests if jit
 is disabled in test_verifier

On Wed, Jan 17, 2024 at 3:10 AM Tiezhu Yang <yangtiezhu@...ngson.cn> wrote:
>
[...]
> @@ -1622,6 +1624,16 @@ static void do_test_single(struct bpf_test *test, bool unpriv,
>         alignment_prevented_execution = 0;
>
>         if (expected_ret == ACCEPT || expected_ret == VERBOSE_ACCEPT) {
> +               if (fd_prog < 0 && saved_errno == EINVAL && jit_disabled) {
> +                       for (i = 0; i < prog_len; i++, prog++) {
> +                               if (!insn_is_pseudo_func(prog))
> +                                       continue;
> +                               printf("SKIP (callbacks are not allowed in non-JITed programs)\n");
> +                               skips++;
> +                               goto close_fds;
> +                       }
> +               }
> +

I would put this chunk above "alignment_prevented_execution = 0;".

@@ -1619,6 +1621,16 @@ static void do_test_single(struct bpf_test
*test, bool unpriv,
                goto close_fds;
        }

+       if (fd_prog < 0 && saved_errno == EINVAL && jit_disabled) {
+               for (i = 0; i < prog_len; i++, prog++) {
+                       if (!insn_is_pseudo_func(prog))
+                               continue;
+                       printf("SKIP (callbacks are not allowed in
non-JITed programs)\n");
+                       skips++;
+                       goto close_fds;
+               }
+       }
+
        alignment_prevented_execution = 0;

        if (expected_ret == ACCEPT || expected_ret == VERBOSE_ACCEPT) {

Other than this,

Acked-by: Song Liu <song@...nel.org>

Thanks,
Song