linux-kernel - Re: [PATCH v1 13/14] arm_mpam: Handle resource instances mapped to different controls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 17 Jan 2024 10:03:00 -0800
From: Peter Newman <peternewman@...gle.com>
To: Amit Singh Tomar <amitsinght@...vell.com>
Cc: linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	fenghua.yu@...el.com, reinette.chatre@...el.com, james.morse@....com, 
	gcherian@...vell.com, robh@...nel.org, dfustini@...libre.com, 
	jonathan.cameron@...wei.com
Subject: Re: [PATCH v1 13/14] arm_mpam: Handle resource instances mapped to
 different controls

Hi Amit,

On Wed, Jan 17, 2024 at 6:15 AM Amit Singh Tomar <amitsinght@...vell.com> wrote:

>
> +/* Club different resource properties under a class that resctrl uses,
> + * for instance, L3 cache that supports both CPOR, and DSPRI need to have
> + * knowledge of both cpbm_wd and dspri_wd. This is needed when two controls
> + * are enumerated under differnt RIS Index.
> + */
> +static void mpam_enable_club_class_features(struct mpam_class *class,
> +                                           struct mpam_msc_ris *ris)

It looks like "club" is used as a synonym to "class" here to evade the
bigger issue that mpam_classes are not defined correctly as DSPRI
resources should not be in the same mpam_class as the L3 CPOR and CSU
features.

This hardware makes it clear that the definition of mpam_class as all
resources in a (level x {memory,cache}) needs to be revised.

-Peter