linux-kernel - Re: [PATCH v7 6/6] ASoC: cs42l43: Add support for the cs42l43

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b1889bb0-2b9f-477c-80d3-a636b9017ea4@sirena.org.uk>
Date: Thu, 18 Jan 2024 22:07:00 +0000
From: Mark Brown <broonie@...nel.org>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: Charles Keepax <ckeepax@...nsource.cirrus.com>, lee@...nel.org,
	robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
	conor+dt@...nel.org, linus.walleij@...aro.org, vkoul@...nel.org,
	lgirdwood@...il.com, yung-chuan.liao@...ux.intel.com,
	sanyog.r.kale@...el.com, pierre-louis.bossart@...ux.intel.com,
	alsa-devel@...a-project.org, patches@...nsource.cirrus.com,
	devicetree@...r.kernel.org, linux-gpio@...r.kernel.org,
	linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 6/6] ASoC: cs42l43: Add support for the cs42l43

On Thu, Jan 18, 2024 at 10:46:28PM +0200, Andy Shevchenko wrote:
> On Thu, Jan 18, 2024 at 8:11 PM Mark Brown <broonie@...nel.org> wrote:
> > On Thu, Jan 18, 2024 at 07:41:54PM +0200, andy.shevchenko@...il.com wrote:
> > > Fri, Aug 04, 2023 at 11:46:02AM +0100, Charles Keepax kirjoitti:

> > > > +   unsigned int hs2 = 0x2 << CS42L43_HSDET_MODE_SHIFT;

> > > BIT(1) ?

> > Given that this is writing a value into a register field called "MODE"
> > it seems very likely that it's an enumeration value rather than a
> > bitmask (and similarly for all the other places where you're making
> > similar comments).  Please think a bit more about the code being
> > commented on when making these minor stylistic comments.

> I read a bit further and have given a comment about this as you put it
> above that they are plain values.
> Please, read my comments in full.

I did eventually find that while going through the other comments but
given that the earlier ones hadn't been revised and it was all a bunch
of different fields it still seemed useful to highlight, if nothing else
it was a little unclear that your later comment applied to all the
fields you were asking for updates to.

In general in a case like this where the code is already in tree it does
seem like it'd be better to just write patche for the stylistic issues.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)