lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 18 Jan 2024 23:21:43 +0000
From: "Karan Tilak Kumar (kartilak)" <kartilak@...co.com>
To: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        "Satish Kharat
 (satishkh)" <satishkh@...co.com>
CC: "Sesidhar Baddela (sebaddel)" <sebaddel@...co.com>,
        "jejb@...ux.ibm.com"
	<jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com"
	<martin.petersen@...cle.com>,
        "linux-scsi@...r.kernel.org"
	<linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: RE: [PATCH] scsi: fnic: clean up some inconsistent indenting

On Wednesday, January 17, 2024 6:01 PM, Jiapeng Chong <jiapeng.chong@...ux.alibaba.com> wrote:
>
> No functional modification involved.
>
> drivers/scsi/fnic/fnic_scsi.c:1964 fnic_abort_cmd() warn: inconsistent indenting.
>
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7930
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
> drivers/scsi/fnic/fnic_scsi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c index 8d7fc5284293..5b4768e669f0 100644
> --- a/drivers/scsi/fnic/fnic_scsi.c
> +++ b/drivers/scsi/fnic/fnic_scsi.c
> @@ -1961,8 +1961,8 @@ int fnic_abort_cmd(struct scsi_cmnd *sc)
>
> if (!(fnic_priv(sc)->flags & (FNIC_IO_ABORTED | FNIC_IO_DONE))) {
>               spin_unlock_irqrestore(&fnic->wq_copy_lock[hwq], flags);
> -         FNIC_SCSI_DBG(KERN_ERR, fnic->lport->host, fnic->fnic_num,
> -                     "Issuing host reset due to out of order IO\n");
> +             FNIC_SCSI_DBG(KERN_ERR, fnic->lport->host, fnic->fnic_num,
> +                           "Issuing host reset due to out of order IO\n");
>
> ret = FAILED;
> goto fnic_abort_cmd_end;
> --
> 2.20.1.7.g153144c
>

Looks good to me.

Reviewed-by: Karan Tilak Kumar <kartilak@...co.com>

Regards,
Karan

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ