[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CALNs47v4=VatsUVfnNsT9jgtbYxvqhR5mgGMu0zrr18ORQVVNg@mail.gmail.com>
Date: Wed, 17 Jan 2024 19:48:12 -0500
From: Trevor Gross <tmgross@...ch.edu>
To: Valentin Obst <kernel@...entinobst.de>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>,
Wedson Almeida Filho <wedsonaf@...il.com>, Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
Björn Roy Baron <bjorn3_gh@...tonmail.com>,
Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...sung.com>,
Alice Ryhl <aliceryhl@...gle.com>, rust-for-linux@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 06/13] rust: str: move SAFETY comment in front of unsafe block
On Tue, Jan 16, 2024 at 5:36 PM Valentin Obst <kernel@...entinobst.de> wrote:
>
> SAFETY comments should immediately precede the unsafe block they
> justify. Move assignment to `bar` past comment as it is safe.
>
> Signed-off-by: Valentin Obst <kernel@...entinobst.de>
> ---
> rust/kernel/str.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rust/kernel/str.rs b/rust/kernel/str.rs
> index 843ffeec9b3e..fec5c4314758 100644
> --- a/rust/kernel/str.rs
> +++ b/rust/kernel/str.rs
> @@ -191,9 +191,9 @@ pub fn to_str(&self) -> Result<&str, core::str::Utf8Error> {
> /// ```
> /// # use kernel::c_str;
> /// # use kernel::str::CStr;
> + /// let bar = c_str!("ツ");
> /// // SAFETY: String literals are guaranteed to be valid UTF-8
> /// // by the Rust compiler.
> - /// let bar = c_str!("ツ");
> /// assert_eq!(unsafe { bar.as_str_unchecked() }, "ツ");
> /// ```
> #[inline]
> --
> 2.43.0
>
>
Reviewed-by: Trevor Gross <tmgross@...ch.edu>
Powered by blists - more mailing lists