linux-kernel - Re: [PATCH 31/45] tty: vt: use VESA blanking constants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 18 Jan 2024 09:54:36 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Thomas Zimmermann <tzimmermann@...e.de>
Cc: Jiri Slaby <jirislaby@...nel.org>, linux-fbdev@...r.kernel.org,
	linux-parisc@...r.kernel.org, Helge Deller <deller@....de>,
	linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
	"James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
	linux-serial@...r.kernel.org
Subject: Re: [PATCH 31/45] tty: vt: use VESA blanking constants

On Thu, Jan 18, 2024 at 09:41:34AM +0100, Thomas Zimmermann wrote:
> Hi
> 
> Am 18.01.24 um 09:32 schrieb Jiri Slaby:
> > On 18. 01. 24, 9:30, Thomas Zimmermann wrote:
> > > Am 18.01.24 um 08:57 schrieb Jiri Slaby (SUSE):
> > > > There are VESA blanking constants defined in console.h already. So use
> > > > them in the console code instead of constant values.
> > > 
> > > These constants also exist in include/uapi/linux/fb.h. It would be
> > > nice to find a common header where they can be shared.
> > 
> > Hi,
> > 
> > see 32/45.
> > 
> > I actually don't know how to fix that nicely while keeping uapi happy.
> 
> Is it hard to get a new UAPI header accepted (honest question)?

No.

> There are a few things I'd like to split off from fbdev. But that
> would require UAPI headers.

That's fine, create them, but you can't just delete an existing .h file
as that will usually break things.

thanks,

greg k-h