linux-kernel - Re: [PATCH] sh: ecovec24: Rename missed backlight field from fbdev to dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4e4dfece5f2f44c6fc826735ddef67ca3c3ac2dc.camel@physik.fu-berlin.de>
Date: Thu, 18 Jan 2024 15:57:30 +0100
From: John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>
To: Geert Uytterhoeven <geert+renesas@...der.be>, Yoshinori Sato
 <ysato@...rs.sourceforge.jp>, Rich Felker <dalias@...c.org>, Thomas
 Zimmermann <tzimmermann@...e.de>, Sam Ravnborg <sam@...nborg.org>, Daniel
 Thompson <daniel.thompson@...aro.org>
Cc: linux-sh@...r.kernel.org, dri-devel@...ts.freedesktop.org, 
 linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org, kernel test
 robot <lkp@...el.com>
Subject: Re: [PATCH] sh: ecovec24: Rename missed backlight field from fbdev
 to dev

On Mon, 2023-09-25 at 13:10 +0200, Geert Uytterhoeven wrote:
> One instance of gpio_backlight_platform_data.fbdev was renamed, but the
> second instance was forgotten, causing a build failure:
> 
>     arch/sh/boards/mach-ecovec24/setup.c: In function ‘arch_setup’:
>     arch/sh/boards/mach-ecovec24/setup.c:1223:37: error: ‘struct gpio_backlight_platform_data’ has no member named ‘fbdev’; did you mean ‘dev’?
>      1223 |                 gpio_backlight_data.fbdev = NULL;
> 	  |                                     ^~~~~
> 	  |                                     dev
> 
> Fix this by updating the second instance.
> 
> Fixes: ed369def91c1579a ("backlight/gpio_backlight: Rename field 'fbdev' to 'dev'")
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202309231601.Uu6qcRnU-lkp@intel.com/
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
>  arch/sh/boards/mach-ecovec24/setup.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/sh/boards/mach-ecovec24/setup.c b/arch/sh/boards/mach-ecovec24/setup.c
> index 3be293335de54512..7a788d44cc73496c 100644
> --- a/arch/sh/boards/mach-ecovec24/setup.c
> +++ b/arch/sh/boards/mach-ecovec24/setup.c
> @@ -1220,7 +1220,7 @@ static int __init arch_setup(void)
>  		lcdc_info.ch[0].num_modes		= ARRAY_SIZE(ecovec_dvi_modes);
>  
>  		/* No backlight */
> -		gpio_backlight_data.fbdev = NULL;
> +		gpio_backlight_data.dev = NULL;
>  
>  		gpio_set_value(GPIO_PTA2, 1);
>  		gpio_set_value(GPIO_PTU1, 1);

Reviewed-by: John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913