linux-kernel - Re: [PATCH] media: atomisp: ssh_css: Fix a null-pointer dereference in load_video

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2b56b7f3.66be.18d1d200910.Coremail.alexious@zju.edu.cn>
Date: Thu, 18 Jan 2024 23:10:55 +0800 (GMT+08:00)
From: alexious@....edu.cn
To: "Andy Shevchenko" <andy.shevchenko@...il.com>
Cc: "Hans de Goede" <hdegoede@...hat.com>,
	"Mauro Carvalho Chehab" <mchehab@...nel.org>,
	"Sakari Ailus" <sakari.ailus@...ux.intel.com>,
	"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
	"Kate Hsuan" <hpa@...hat.com>, "Dan Carpenter" <error27@...il.com>,
	"Brent Pappas" <bpappas@...pasbrent.com>,
	linux-media@...r.kernel.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: atomisp: ssh_css: Fix a null-pointer dereference
 in load_video_binaries

> On Wed, Jan 17, 2024 at 8:34 AM <alexious@....edu.cn> wrote:
> > > On Fri, Jan 12, 2024 at 10:49 AM Hans de Goede <hdegoede@...hat.com> wrote:
> > > > On 1/12/24 09:34, Zhipeng Lu wrote:
> 
> > > > > Fixes: ad85094b293e ("Revert "media: staging: atomisp: Remove driver"")
> > > Besides that, are you sure the Fixes refers to the correct commit?
> >
> > Well, I think I referred to the correct commit, which introduce the whole module and leave this bug.
> >
> > If I did miss something please let me know.
> 
> Yes, the driver was before that commit in the kernel. Was it without
> the bug? No, because you are referring to a clear revert. So, find the
> real commit that had brought that into the kernel.

You are correct, I just did some git blame on the latest version but 
forgot about the commit blamed was a revert commit.
A v2 version of this patch will be sent later to fix this issue.
Thank you for pointing out my mistake.

Regards,
Zhipeng

> 
> -- 
> With Best Regards,
> Andy Shevchenko