linux-kernel - Re: [PATCH] block: Move checking GENHD_FL_NO_PART to bdev_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f6e687cc-debd-4864-901a-fb35be9f2adc@kernel.dk>
Date: Thu, 18 Jan 2024 08:20:31 -0700
From: Jens Axboe <axboe@...nel.dk>
To: Li Lingfeng <lilingfeng@...weicloud.com>, allison.karlitskaya@...hat.com,
 hch@...radead.org, yukuai1@...weicloud.com
Cc: linux-kernel@...r.kernel.org, linux-block@...r.kernel.org,
 houtao1@...wei.com, yi.zhang@...wei.com, yangerkun@...wei.com,
 Yu Kuai <yukuai1@...weicloud.com>
Subject: Re: [PATCH] block: Move checking GENHD_FL_NO_PART to
 bdev_add_partition()

On 1/18/24 6:04 AM, Li Lingfeng wrote:
> From: Li Lingfeng <lilingfeng3@...wei.com>
> 
> Commit 1a721de8489f ("block: don't add or resize partition on the disk
> with GENHD_FL_NO_PART") prevented all operations about partitions on disks
> with GENHD_FL_NO_PART in blkpg_do_ioctl() since they are meaningless.
> However, it changed error code in some scenarios. So move checking
> GENHD_FL_NO_PART to bdev_add_partition() to eliminate impact.

This looks fine, but it's identical to the one sent out by Yu two days
ago. Hmm? Who's the proper author?

Adding Yu.

-- 
Jens Axboe