| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id:
<20240118-update-dump-stack-arch-str-v1-5-5c0f98d017b5@linux.ibm.com>
Date: Thu, 18 Jan 2024 09:25:16 -0600
From: Nathan Lynch via B4 Relay <devnull+nathanl.linux.ibm.com@...nel.org>
To: "Aneesh Kumar K.V" <aneesh.kumar@...ux.ibm.com>,
"Naveen N. Rao" <naveen.n.rao@...ux.ibm.com>,
Brian King <brking@...ux.ibm.com>,
Christophe Leroy <christophe.leroy@...roup.eu>,
John Ogness <john.ogness@...utronix.de>,
Michael Ellerman <mpe@...erman.id.au>, Nicholas Piggin <npiggin@...il.com>,
Petr Mladek <pmladek@...e.com>,
Sergey Senozhatsky <senozhatsky@...omium.org>,
Steven Rostedt <rostedt@...dmis.org>
Cc: linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
Nathan Lynch <nathanl@...ux.ibm.com>
Subject: [PATCH RFC 5/5] powerpc/pseries: Update hardware description
string after migration
From: Nathan Lynch <nathanl@...ux.ibm.com>
Introduce code that rebuilds the short hardware description printed by
stack traces. This sort of duplicates some code from boot (prom.c
mainly), but that code populates the string as early as possible using
APIs that aren't available later. So sharing all the code between the
boot and runtime versions isn't feasible.
To prevent "drift" between the boot and runtime versions, rebuild the
description using the new runtime APIs in a late initcall and warn if
it doesn't match the one built earlier. The initcall also invokes
dump_stack_update_arch_desc() twice to fully exercise it before any
partition migration occurs. These checks could be dropped or made
configurable later.
Call pseries_update_hw_description() immediately after updating the
device tree when resuming from a partition migration.
Signed-off-by: Nathan Lynch <nathanl@...ux.ibm.com>
---
arch/powerpc/platforms/pseries/mobility.c | 5 +++
arch/powerpc/platforms/pseries/pseries.h | 1 +
arch/powerpc/platforms/pseries/setup.c | 70 +++++++++++++++++++++++++++++++
3 files changed, 76 insertions(+)
diff --git a/arch/powerpc/platforms/pseries/mobility.c b/arch/powerpc/platforms/pseries/mobility.c
index 1798f0f14d58..ff573cb5aee5 100644
--- a/arch/powerpc/platforms/pseries/mobility.c
+++ b/arch/powerpc/platforms/pseries/mobility.c
@@ -378,6 +378,11 @@ void post_mobility_fixup(void)
rc = pseries_devicetree_update(MIGRATION_SCOPE);
if (rc)
pr_err("device tree update failed: %d\n", rc);
+ /*
+ * Rebuild the hardware description printed in stack traces
+ * using the updated device tree.
+ */
+ pseries_update_hw_description();
cacheinfo_rebuild();
diff --git a/arch/powerpc/platforms/pseries/pseries.h b/arch/powerpc/platforms/pseries/pseries.h
index bba4ad192b0f..810a64fccc7e 100644
--- a/arch/powerpc/platforms/pseries/pseries.h
+++ b/arch/powerpc/platforms/pseries/pseries.h
@@ -56,6 +56,7 @@ extern int dlpar_acquire_drc(u32 drc_index);
extern int dlpar_release_drc(u32 drc_index);
extern int dlpar_unisolate_drc(u32 drc_index);
extern void post_mobility_fixup(void);
+void pseries_update_hw_description(void);
void queue_hotplug_event(struct pseries_hp_errorlog *hp_errlog);
int handle_dlpar_errorlog(struct pseries_hp_errorlog *hp_errlog);
diff --git a/arch/powerpc/platforms/pseries/setup.c b/arch/powerpc/platforms/pseries/setup.c
index 9ae1951f8312..72177411026e 100644
--- a/arch/powerpc/platforms/pseries/setup.c
+++ b/arch/powerpc/platforms/pseries/setup.c
@@ -1034,6 +1034,76 @@ static void pseries_add_hw_description(struct seq_buf *sb)
seq_buf_printf(sb, "hv:phyp ");
}
+static void pseries_rebuild_hw_desc(struct seq_buf *sb)
+{
+ struct device_node *cpudn, *root;
+ const char *model;
+ u32 cpu_version;
+
+ seq_buf_clear(sb);
+
+ root = of_find_node_by_path("/");
+ if (!of_property_read_string(root, "model", &model))
+ seq_buf_printf(sb, "%s ", model);
+ of_node_put(root);
+
+ seq_buf_printf(sb, "%s 0x%04lx ", cur_cpu_spec->cpu_name, mfspr(SPRN_PVR));
+
+ cpudn = of_get_next_cpu_node(NULL);
+ if (!of_property_read_u32(cpudn, "cpu-version", &cpu_version)) {
+ if ((cpu_version & 0xff000000) == 0x0f000000)
+ seq_buf_printf(sb, "0x%04x ", cpu_version);
+ }
+ of_node_put(cpudn);
+
+ pseries_add_hw_description(sb);
+
+ seq_buf_puts(sb, ppc_md.name);
+}
+
+void pseries_update_hw_description(void)
+{
+ struct seq_buf sb = { // todo: use DECLARE_SEQ_BUF() once it's fixed
+ .buffer = (char[128]) { 0 },
+ .size = sizeof(char[128]),
+ };
+
+ pseries_rebuild_hw_desc(&sb);
+ dump_stack_update_arch_desc("%s", seq_buf_str(&sb));
+}
+
+static int __init pseries_test_update_hw_desc(void)
+{
+ struct seq_buf sb = { // todo: use DECLARE_SEQ_BUF() once it's fixed
+ .buffer = (char[128]) { 0 },
+ .size = sizeof(char[128]),
+ };
+ bool mismatch;
+
+ /*
+ * Ensure the rebuilt description matches the one built during
+ * boot.
+ */
+ pseries_rebuild_hw_desc(&sb);
+
+ mismatch = strcmp(seq_buf_str(&ppc_hw_desc), seq_buf_str(&sb));
+ if (WARN(mismatch, "rebuilt hardware description string mismatch")) {
+ pr_err(" boot: '%s'\n", ppc_hw_desc.buffer);
+ pr_err(" runtime: '%s'\n", sb.buffer);
+ return -EINVAL;
+ }
+
+ /*
+ * Invoke dump_stack_update_arch_desc() *twice* to ensure it
+ * exercises the free path.
+ */
+ dump_stack_update_arch_desc("%s", sb.buffer);
+ dump_stack_update_arch_desc("%s", sb.buffer);
+
+ return 0;
+}
+late_initcall(pseries_test_update_hw_desc);
+
/*
* Early initialization. Relocation is on but do not reference unbolted pages
*/
--
2.43.0
Powered by blists - more mailing lists