linux-kernel - Re: [PATCH v2 08/17] serial: max310x: use separate regmap name for each port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20240118104443.7678d39eafc698a4baeb2ce7@hugovil.com>
Date: Thu, 18 Jan 2024 10:44:43 -0500
From: Hugo Villeneuve <hugo@...ovil.com>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: gregkh@...uxfoundation.org, jirislaby@...nel.org,
 cosmin.tanislav@...log.com, shc_work@...l.ru, linux-kernel@...r.kernel.org,
 linux-serial@...r.kernel.org, Hugo Villeneuve <hvilleneuve@...onoff.com>,
 Jan Kundrát <jan.kundrat@...net.cz>
Subject: Re: [PATCH v2 08/17] serial: max310x: use separate regmap name for
 each port

On Thu, 18 Jan 2024 17:30:16 +0200
Andy Shevchenko <andy.shevchenko@...il.com> wrote:

> On Thu, Jan 18, 2024 at 5:22 PM Hugo Villeneuve <hugo@...ovil.com> wrote:
> >
> > From: Hugo Villeneuve <hvilleneuve@...onoff.com>
> >
> > Use a separate regmap name for each port so they can each have their own
> > debugfs entry, allowing to access each port registers independently.
> >
> > For example, a four channels/ports device like the MAX14830 will have four
> > entries in its regmap debugfs:
> >
> > $ find /sys/kernel/debug/regmap -type d | grep spi0.0
> 
> Just a side note for the future. The above is an example of "Useless
> use of grep".
> `find` has a `-name` parameter for such, using `find ...-name
> 'spi0.0*'` makes the grep unnecessary.

Hi,
yes, I fixed a similar one in the sc16is7xx serie, but forgot to update
this one :)

Will fix it if sending V3.

Hugo Villeneuve


> 
> > /sys/kernel/debug/regmap/spi0.0-port0
> > /sys/kernel/debug/regmap/spi0.0-port1
> > /sys/kernel/debug/regmap/spi0.0-port2
> > /sys/kernel/debug/regmap/spi0.0-port3
> 
> -- 
> With Best Regards,
> Andy Shevchenko