linux-kernel - Re: [PATCH v7 0/6] Add cs42l43 PC focused SoundWire CODEC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZalYooJxj7Ba0sYU@surfacebook.localdomain>
Date: Thu, 18 Jan 2024 18:58:10 +0200
From: andy.shevchenko@...il.com
To: Charles Keepax <ckeepax@...nsource.cirrus.com>
Cc: broonie@...nel.org, lee@...nel.org, robh+dt@...nel.org,
	krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
	linus.walleij@...aro.org, vkoul@...nel.org, lgirdwood@...il.com,
	yung-chuan.liao@...ux.intel.com, sanyog.r.kale@...el.com,
	pierre-louis.bossart@...ux.intel.com, alsa-devel@...a-project.org,
	patches@...nsource.cirrus.com, devicetree@...r.kernel.org,
	linux-gpio@...r.kernel.org, linux-spi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 0/6] Add cs42l43 PC focused SoundWire CODEC

Fri, Aug 04, 2023 at 11:45:56AM +0100, Charles Keepax kirjoitti:
> This patch chain adds support for the Cirrus Logic cs42l43 PC focused
> SoundWire CODEC. The chain is currently based of Lee's for-mfd-next
> branch.
> 
> This series is mostly just a resend keeping pace with the kernel under
> it, except for a minor fixup in the ASoC stuff.


Sorry for the late review, nevertheless, I was alerted by the pin control code
probe function that does something custom with devlinks. This is a red flag,
please find time to fix that.

The rest of the review (since the code is in upstream) is probably good to have
via follow up cleanups.

-- 
With Best Regards,
Andy Shevchenko