linux-kernel - Re: [PATCH] drivers: watchdog: Add ChromeOS EC watchdog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <82563d8e-5987-4a1b-8265-22d20f8d6902@roeck-us.net>
Date: Thu, 18 Jan 2024 10:17:50 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Łukasz Majczak <lma@...omium.org>
Cc: Gwendal Grignou <gwendal@...omium.org>, Lee Jones <lee@...nel.org>,
 Benson Leung <bleung@...omium.org>, Wim Van Sebroeck
 <wim@...ux-watchdog.org>, Tzung-Bi Shih <tzungbi@...nel.org>,
 Radoslaw Biernacki <biernacki@...gle.com>, linux-kernel@...r.kernel.org,
 chrome-platform@...ts.linux.dev, linux-watchdog@...r.kernel.org
Subject: Re: [PATCH] drivers: watchdog: Add ChromeOS EC watchdog

On 1/18/24 10:08, Łukasz Majczak wrote:
> Hi Guenter
> 
> Please see my comments below
> 
> On Wed, Jan 17, 2024 at 5:23 PM Guenter Roeck <linux@...ck-us.net> wrote:
>>
>> On 1/17/24 02:24, Lukasz Majczak wrote:
>>> This adds EC-based watchdog support for ChromeOS
>>> based devices equipped with embedded controller (EC).
>>>
>>> Signed-off-by: Lukasz Majczak <lma@...omium.org>
>>
>> checkpatch --strict says:
>>
>> total: 0 errors, 0 warnings, 14 checks, 455 lines checked
>>
>> Please fix.
> 
> ACK, Although I would keep uint16_t/uint32_t types in
> cros_ec_commands.h as those are shared with EC firmware.
> 

Makes sense. Thanks!

Guenter