linux-kernel - Re: [PATCH] perf build: don't hardcode pkg-config path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM9d7cikvOQvUXMrRPM9g6W34zHJsbNquhJYiV9AgS40eGC3qw@mail.gmail.com>
Date: Thu, 18 Jan 2024 21:16:01 -0800
From: Namhyung Kim <namhyung@...nel.org>
To: Jan Kundrát <jan.kundrat@...net.cz>
Cc: linux-perf-users@...r.kernel.org, 
	"Yann E. MORIN" <yann.morin.1998@...e.fr>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf build: don't hardcode pkg-config path

Hello,

On Wed, Jan 17, 2024 at 7:58 AM Jan Kundrát <jan.kundrat@...net.cz> wrote:
>
> On Buildroot and when building for Arm using the Bootlin toolchain, the
> actual `pkg-config` is named just `pkg-config`, not
> `arm-linux-pkg-config`. This patch allows the external build system
> (such as Buildroot) to pass a working path.
>
> This is already done correctly in tools/build/feature/Makefile and
> tools/thermal/tmon/Makefile and also fixed in other places many years
> ago (9961aa665b70e47d6c80141c4a2482266010f246), but for some reason it
> was never fixed in this file.
>
> Signed-off-by: Jan Kundrát <jan.kundrat@...net.cz>
> To: linux-perf-users@...r.kernel.org
> Cc: Yann E. MORIN <yann.morin.1998@...e.fr>
> Cc: linux-kernel@...r.kernel.org

Acked-by: Namhyung Kim <namhyung@...nel.org>

Thanks,
Namhyung


> ---
>  tools/perf/Makefile.perf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> index 86569f230e60..b69ab2ae77c6 100644
> --- a/tools/perf/Makefile.perf
> +++ b/tools/perf/Makefile.perf
> @@ -188,7 +188,7 @@ HOSTLD  ?= ld
>  HOSTAR  ?= ar
>  CLANG   ?= clang
>
> -PKG_CONFIG = $(CROSS_COMPILE)pkg-config
> +PKG_CONFIG ?= $(CROSS_COMPILE)pkg-config
>
>  RM      = rm -f
>  LN      = ln -f
> --
> 2.43.0
>
>
>