linux-kernel - Re: [PATCH v3 2/2] tty/sysrq: Dump printk ring buffer messages via sysrq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024011958-coerce-niece-6301@gregkh>
Date: Fri, 19 Jan 2024 06:47:13 +0100
From: "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To: David Laight <David.Laight@...lab.com>
Cc: 'Sreenath Vijayan' <sreenath.vijayan@...y.com>,
	"john.ogness@...utronix.de" <john.ogness@...utronix.de>,
	"corbet@....net" <corbet@....net>,
	"jirislaby@...nel.org" <jirislaby@...nel.org>,
	"rdunlap@...radead.org" <rdunlap@...radead.org>,
	"pmladek@...e.com" <pmladek@...e.com>,
	"rostedt@...dmis.org" <rostedt@...dmis.org>,
	"senozhatsky@...omium.org" <senozhatsky@...omium.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
	"taichi.shimoyashiki@...y.com" <taichi.shimoyashiki@...y.com>,
	"daniel.palmer@...y.com" <daniel.palmer@...y.com>,
	"anandakumar.balasubramaniam@...y.com" <anandakumar.balasubramaniam@...y.com>
Subject: Re: [PATCH v3 2/2] tty/sysrq: Dump printk ring buffer messages via
 sysrq

On Thu, Jan 18, 2024 at 10:56:59PM +0000, David Laight wrote:
> From: Sreenath Vijayan
> > Sent: 17 January 2024 11:14
> ....
> >  /* Key Operations table and lock */
> >  static DEFINE_SPINLOCK(sysrq_key_table_lock);
> > 
> > @@ -505,7 +523,7 @@ static const struct sysrq_key_op *sysrq_key_table[62] = {
> >  	NULL,				/* A */
> >  	NULL,				/* B */
> >  	NULL,				/* C */
> > -	NULL,				/* D */
> > +	&sysrq_dmesg_dump_op,		/* D */
> >  	NULL,				/* E */
> >  	NULL,				/* F */
> >  	NULL,				/* G */
> 
> That looks like it ought to use C99 initialisers:
> 	['D' - 'A'] = &sysrq_dmesg_dump_op,
> 
> Possible with a #define to hide the offset.

Maybe in the future, but for now, let's leave it as-is please.

thanks,

greg k-h