linux-kernel - Re: [PATCH 1/4] drm: xlnx: zynqmp_dpsub: Make drm bridge discoverable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date: Fri, 19 Jan 2024 05:50:41 +0000
From: "Klymenko, Anatoliy" <Anatoliy.Klymenko@....com>
To: Laurent Pinchart <laurent.pinchart@...asonboard.com>, Tomi Valkeinen
	<tomi.valkeinen@...asonboard.com>, "maarten.lankhorst@...ux.intel.com"
	<maarten.lankhorst@...ux.intel.com>, "mripard@...nel.org"
	<mripard@...nel.org>, "tzimmermann@...e.de" <tzimmermann@...e.de>,
	"airlied@...il.com" <airlied@...il.com>, "daniel@...ll.ch" <daniel@...ll.ch>,
	"Simek, Michal" <michal.simek@....com>, "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/4] drm: xlnx: zynqmp_dpsub: Make drm bridge discoverable

Hi Laurent,

Thank you for the reply.

> Date: Wed, 17 Jan 2024 16:24:20 +0200
> From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> To: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
> Cc: Anatoliy Klymenko <anatoliy.klymenko@....com>,
>         maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
>         tzimmermann@...e.de, airlied@...il.com, daniel@...ll.ch,
>         michal.simek@....com, dri-devel@...ts.freedesktop.org,
>         linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
> Subject: Re: [PATCH 1/4] drm: xlnx: zynqmp_dpsub: Make drm bridge
>         discoverable
> Message-ID: <20240117142420.GE17920@...dragon.ideasonboard.com>
> Content-Type: text/plain; charset=utf-8
> 
> On Wed, Jan 17, 2024 at 04:06:31PM +0200, Tomi Valkeinen wrote:
> > On 13/01/2024 01:42, Anatoliy Klymenko wrote:
> > > Assign device of node to bridge prior registering it. This will make
> > > said bridge discoverable by separate crtc driver.
> >
> > I think a few words on why this is needed (and why it wasn't needed
> > before) would be nice.
> >
> > Other than that:
> >
> > Reviewed-by: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
> 
> Agreed. With a better commit message,
> 

Sure, I will update commit message in the next version.

> Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> 
> > > Signed-off-by: Anatoliy Klymenko <anatoliy.klymenko@....com>
> > > ---
> > >   drivers/gpu/drm/xlnx/zynqmp_dp.c | 1 +
> > >   1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c
> > > b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> > > index a0606fab0e22..d60b7431603f 100644
> > > --- a/drivers/gpu/drm/xlnx/zynqmp_dp.c
> > > +++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> > > @@ -1721,6 +1721,7 @@ int zynqmp_dp_probe(struct zynqmp_dpsub
> *dpsub)
> > >     bridge->ops = DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID
> > >                 | DRM_BRIDGE_OP_HPD;
> > >     bridge->type = DRM_MODE_CONNECTOR_DisplayPort;
> > > +   bridge->of_node = dp->dev->of_node;
> > >     dpsub->bridge = bridge;
> > >
> > >     /*
> 
> --
> Regards,
> 
> Laurent Pinchart
> 
> 

Thank you,
Anatoliy