linux-kernel - Re: [PATCH v2 1/3] platform/chrome: Update binary interface for EC-based watchdog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE5UKNqa8kbcjNmWb4=m4tLJJKStUaYYP1OMVkqr2T3Xgdz_MA@mail.gmail.com>
Date: Fri, 19 Jan 2024 09:34:48 +0100
From: Łukasz Majczak <lma@...omium.org>
To: Tzung-Bi Shih <tzungbi@...nel.org>
Cc: Gwendal Grignou <gwendal@...omium.org>, Radoslaw Biernacki <biernacki@...gle.com>, 
	Wim Van Sebroeck <wim@...ux-watchdog.org>, Lee Jones <lee@...nel.org>, 
	Benson Leung <bleung@...omium.org>, Guenter Roeck <groeck@...omium.org>, 
	Krzysztof Kozlowski <krzk@...nel.org>, linux-watchdog@...r.kernel.org, 
	linux-kernel@...r.kernel.org, chrome-platform@...ts.linux.dev
Subject: Re: [PATCH v2 1/3] platform/chrome: Update binary interface for
 EC-based watchdog

On Fri, Jan 19, 2024 at 4:41 AM Tzung-Bi Shih <tzungbi@...nel.org> wrote:
>
> On Thu, Jan 18, 2024 at 07:53:22PM +0000, Lukasz Majczak wrote:
> > +#define EC_HANG_DETECT_MIN_TIMEOUT 5
> > +#define EC_HANG_DETECT_MAX_TIMEOUT 65535
>
> EC_HANG_DETECT_MAX_TIMEOUT isn't in the latest ec_commands.h [1].  Could you
> either add EC_HANG_DETECT_MAX_TIMEOUT to ec_commands.h or drop the macro here?
>
> [1] https://crrev.com/5a76e67210b15fcf67d8a6f90439993598949ae4/include/ec_commands.h#4749

Yes, I will update ec_commands.h on the EC-side to match above
definitions although it doesn't influence any logic on the EC side.

Best regards
Lukasz