linux-kernel - Re: [PATCH v2 1/2] dt-bindings: backlight: add Kinetic KTD2801 binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdY72JLKTC=1agqHFzOPaTwBe2Y-OfCkeUUYGz13J-5r=Q@mail.gmail.com>
Date: Fri, 19 Jan 2024 09:48:08 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: Duje Mihanović <duje.mihanovic@...le.hr>
Cc: Lee Jones <lee@...nel.org>, Daniel Thompson <daniel.thompson@...aro.org>, 
	Jingoo Han <jingoohan1@...il.com>, Pavel Machek <pavel@....cz>, Rob Herring <robh+dt@...nel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>, 
	Helge Deller <deller@....de>, Karel Balej <balejk@...fyz.cz>, ~postmarketos/upstreaming@...ts.sr.ht, 
	dri-devel@...ts.freedesktop.org, linux-leds@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-fbdev@...r.kernel.org, 
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: backlight: add Kinetic KTD2801 binding

Hi Duje,

thanks for your patch!

On Thu, Jan 18, 2024 at 6:33 PM Duje Mihanović <duje.mihanovic@...le.hr> wrote:

> Add the dt binding for the Kinetic KTD2801 backlight driver.

Maybe add some commit message?

> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Signed-off-by: Duje Mihanović <duje.mihanovic@...le.hr>
(...)
> +  ctrl-gpios:
> +    maxItems: 1

First I thought this was inconsistent with ktd253, then
I looked at the datasheets and they really did change "en" to "ctrl" so
this needs a new name indeed.

With commit message added:
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij