linux-kernel - Re: regression/bisected commit 773688a6cb24b0b3c2ba40354d883348a2befa38 make my system completely unusable under high load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANpmjNM=92PcmODNPB4DrAhfLY=0mePCbyG9=8BGrQ4MC0xZ6w@mail.gmail.com>
Date: Fri, 19 Jan 2024 11:59:54 +0100
From: Marco Elver <elver@...gle.com>
To: Mikhail Gavrilov <mikhail.v.gavrilov@...il.com>
Cc: glider@...gle.com, dvyukov@...gle.com, eugenis@...gle.com, 
	Oscar Salvador <osalvador@...e.de>, Vlastimil Babka <vbabka@...e.cz>, 
	Andrew Morton <akpm@...ux-foundation.org>, 
	Linux List Kernel Mailing <linux-kernel@...r.kernel.org>, 
	Linux Memory Management List <linux-mm@...ck.org>, Andrey Konovalov <andreyknvl@...il.com>
Subject: Re: regression/bisected commit 773688a6cb24b0b3c2ba40354d883348a2befa38
 make my system completely unusable under high load

On Fri, 19 Jan 2024 at 11:54, Marco Elver <elver@...gle.com> wrote:
>
> On Fri, 19 Jan 2024 at 11:46, Mikhail Gavrilov
> <mikhail.v.gavrilov@...il.com> wrote:
> >
> > Hi,
> > I use a system with KASAN sanitizer everyday.
> > Because I want to catch difficult-to-repeat bugs.
> > And all worked fine until commit 773688a6cb24b0b3c2ba40354d883348a2befa38.
> > After commit 773688a6cb24b0b3c2ba40354d883348a2befa38 all working
> > jerky when I compile something.
> > The sound is interrupted, the cursor moves jerkily if I try to do
> > anything when all the cores are loaded.
> >
> > > git bisect bad
> > 773688a6cb24b0b3c2ba40354d883348a2befa38 is the first bad commit
> > commit 773688a6cb24b0b3c2ba40354d883348a2befa38
> > Author: Andrey Konovalov <andreyknvl@...gle.com>
> > Date:   Mon Nov 20 18:47:19 2023 +0100
> >
> >     kasan: use stack_depot_put for Generic mode
> [...]
> >  mm/kasan/common.c     |  3 ++-
> >  mm/kasan/generic.c    | 22 ++++++++++++++++++----
> >  mm/kasan/quarantine.c | 26 ++++++++++++++++++++------
> >  3 files changed, 40 insertions(+), 11 deletions(-)
> >
> > I attached here my build .config and kernel log.
> > Who could dig into it, please?
>
> I was afraid this would happen - could you try this patch series:
> https://lore.kernel.org/all/20240118110216.2539519-2-elver@google.com/ [1]

In addition, could you give some additional details about the number
of CPUs in your system?
And if possible, do you have a way to measure performance besides the
obvious lagging of the system? It would be interesting to know if the
fix in [1] regains performance fully.

One major difference is still that an atomic RMW is in the fast paths.
This could be fixed by reverting
773688a6cb24b0b3c2ba40354d883348a2befa38 on top of everything else,
but we're not sure yet that's necessary because the cost of an atomic
RMW really depends on the system you're working with.