linux-kernel - Re: [PATCH v4 3/7] padata: dispatch works on different nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2aeb7d61-5080-4089-b789-765399db74c8@linux.dev>
Date: Fri, 19 Jan 2024 23:04:08 +0800
From: Gang Li <gang.li@...ux.dev>
To: Muchun Song <muchun.song@...ux.dev>
Cc: linux-mm@...ck.org, David Hildenbrand <david@...hat.com>,
 David Rientjes <rientjes@...gle.com>, Mike Kravetz
 <mike.kravetz@...cle.com>, Andrew Morton <akpm@...ux-foundation.org>,
 Tim Chen <tim.c.chen@...ux.intel.com>, linux-kernel@...r.kernel.org,
 ligang.bdlg@...edance.com
Subject: Re: [PATCH v4 3/7] padata: dispatch works on different nodes

On 2024/1/19 10:59, Muchun Song wrote:
> On 2024/1/18 20:39, Gang Li wrote:
>> --- a/kernel/padata.c
>> +++ b/kernel/padata.c
>> @@ -485,7 +485,8 @@ void __init padata_do_multithreaded(struct 
>> padata_mt_job *job)
>>       struct padata_work my_work, *pw;
>>       struct padata_mt_job_state ps;
>>       LIST_HEAD(works);
>> -    int nworks;
>> +    int nworks, nid;
>> +    static atomic_t last_used_nid = ATOMIC_INIT(0);
> last_used_nid is only used during boot time so it could be
> __init_data. Otherwise, LGTM.
> 
> Reviewed-by: Muchun Song <muchun.song@...ux.dev>
> 

OK, thanks.