linux-kernel - Re: [PATCH] string: Remove strlcpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VerSqay6cxRQOihC321BbpAWd_TB6aPigN8XZZ=KPXtHA@mail.gmail.com>
Date: Fri, 19 Jan 2024 18:05:19 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Kees Cook <keescook@...omium.org>
Cc: Andy Shevchenko <andy@...nel.org>, Azeem Shaikh <azeemshaikh38@...il.com>, 
	Andrew Morton <akpm@...ux-foundation.org>, Andy Whitcroft <apw@...onical.com>, 
	Joe Perches <joe@...ches.com>, Dwaipayan Ray <dwaipayanray1@...il.com>, 
	Lukas Bulwahn <lukas.bulwahn@...il.com>, linux-hardening@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] string: Remove strlcpy()

On Fri, Jan 19, 2024 at 12:33 AM Kees Cook <keescook@...omium.org> wrote:
>
> With all the users of strlcpy() removed[1] from the kernel, remove the
> API, self-tests, and other references. Leave mentions in Documentation
> (about its deprecation), and in checkpatch.pl (to help migrate host-only
> tools/ usage). Long live strscpy().

..

>   * Copies at most dstsize - 1 bytes into the destination buffer.
> - * Unlike strlcpy the destination buffer is always padded out.
> + * Unlike strscpy the destination buffer is always padded out.

While at it, please use the strscpy() form to refer to the function.

With that,
Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

-- 
With Best Regards,
Andy Shevchenko