[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <828dd9ba-60f1-419b-9121-204d622739d3@bootlin.com>
Date: Fri, 19 Jan 2024 17:25:30 +0100
From: Thomas Richard <thomas.richard@...tlin.com>
To: Peter Rosin <peda@...ntia.se>, Linus Walleij <linus.walleij@...aro.org>,
Bartosz Golaszewski <brgl@...ev.pl>, Andy Shevchenko <andy@...nel.org>,
Tony Lindgren <tony@...mide.com>, Haojian Zhuang
<haojian.zhuang@...aro.org>, Vignesh R <vigneshr@...com>,
Aaro Koskinen <aaro.koskinen@....fi>,
Janusz Krzysztofik <jmkrzyszt@...il.com>, Andi Shyti
<andi.shyti@...nel.org>, Vinod Koul <vkoul@...nel.org>,
Kishon Vijay Abraham I <kishon@...nel.org>,
Philipp Zabel <p.zabel@...gutronix.de>, Tom Joseph <tjoseph@...ence.com>,
Lorenzo Pieralisi <lpieralisi@...nel.org>,
Krzysztof Wilczyński <kw@...ux.com>,
Rob Herring <robh@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>
Cc: linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-omap@...r.kernel.org,
linux-i2c@...r.kernel.org, linux-phy@...ts.infradead.org,
linux-pci@...r.kernel.org, gregory.clement@...tlin.com,
theo.lebrun@...tlin.com, thomas.petazzoni@...tlin.com, u-kumar1@...com
Subject: Re: [PATCH 04/14] mux: mmio: Add resume support
Hello Peter,
Thanks for the review.
On 1/15/24 23:31, Peter Rosin wrote:
> Hi!
>
> 2024-01-15 at 17:14, Thomas Richard wrote:
>> From: Théo Lebrun <theo.lebrun@...tlin.com>
>>
>> Implement resume support
>
> What Andy said, and please don't omit punctuation. Try to make it a
> pleasure to read your patches!
Yes my commit message needs to be more verbose, sorry.
>
>>
>> Signed-off-by: Théo Lebrun <theo.lebrun@...tlin.com>
>> Signed-off-by: Thomas Richard <thomas.richard@...tlin.com>
>> ---
>> drivers/mux/mmio.c | 34 ++++++++++++++++++++++++++++++++++
>> 1 file changed, 34 insertions(+)
>>
>> diff --git a/drivers/mux/mmio.c b/drivers/mux/mmio.c
>> index fd1d121a584b..ab4ef195fc0d 100644
>> --- a/drivers/mux/mmio.c
>> +++ b/drivers/mux/mmio.c
>> @@ -125,13 +125,47 @@ static int mux_mmio_probe(struct platform_device *pdev)
>>
>> mux_chip->ops = &mux_mmio_ops;
>>
>> + dev_set_drvdata(dev, mux_chip);
>> +
>> return devm_mux_chip_register(dev, mux_chip);
>> }
>>
>> +#ifdef CONFIG_PM
>> +static int mux_mmio_resume_noirq(struct device *dev)
>> +{
>> + struct mux_chip *mux_chip = dev_get_drvdata(dev);
>> + int global_ret = 0;
>> + unsigned int i;
>> +
>> + for (i = 0; i < mux_chip->controllers; i++) {
>> + struct mux_control *mux = &mux_chip->mux[i];
>> + int val = mux->cached_state;
>
> You are not supposed to look at (or change) cached_state outside the
> mux core.
>
>> + int ret;
>> +
>> + if (val == MUX_IDLE_AS_IS)
>
> The cached_state can never be MUX_IDLE_AS_IS. Sure, it happens to have
> the same actual value as the correct MUX_CACHE_UNKNOWN, but abusing
> that is all kinds of wrong.
>
>> + continue;
>> +
>> + ret = mux_mmio_set(mux, val);
>> + if (ret) {
>
> If mux_mmio_set() fails, cached_state ends up wrong as it should be set
> to MUX_CACHE_UNKNOWN on failure. Low-level stuff like this needs to be
> done by the mux core, or things becomes a maintenance hazard...
>
> So, the meat of this function belongs in the mux core since none of
> it looks mmio specific. It could probably be named mux_chip_resume()
> or something such. That makes it simple to use the correct constant,
> and the mux_control_set() helper makes it easy to get the handling of
> cached_state right.
>
Thanks for the explanations.
So I created a mux_chip_resume function in the mux core.
This function restores each mux using mux_control_set.
The restored state is the cached state.
The muxes with a MUX_CACHE_UNKNOWN cache state are ignored.
So this patch will be splitted, one patch for the core, one for the mmio
driver.
Regards,
--
Thomas Richard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Powered by blists - more mailing lists