linux-kernel - Re: [PATCH v2 1/2] dt-bindings: usb: mt6360-tcpc: Drop interrupt-names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 19 Jan 2024 16:32:37 +0000
From: Conor Dooley <conor@...nel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Cc: chunfeng.yun@...iatek.com, gregkh@...uxfoundation.org,
	robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
	conor+dt@...nel.org, matthias.bgg@...il.com, linux@...ck-us.net,
	heikki.krogerus@...ux.intel.com, cy_huang@...htek.com,
	linux-usb@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: usb: mt6360-tcpc: Drop
 interrupt-names

On Fri, Jan 19, 2024 at 10:41:04AM +0100, AngeloGioacchino Del Regno wrote:
> This IP has only one interrupt, hence interrupt-names is not necessary
> to have.
> Since there is no user yet, simply remove interrupt-names.

I'm a bit confused chief. Patch 2 in this series removes a user of this
property from a driver, so can you explain how this statement is true?

Maybe I need to drink a few cans of Monster and revisit this patchset?

Thanks,
Conor.

> ---
>  .../devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml        | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml b/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml
> index 053264e60583..339bc9c00ac0 100644
> --- a/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml
> +++ b/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml
> @@ -22,10 +22,6 @@ properties:
>    interrupts:
>      maxItems: 1
>  
> -  interrupt-names:
> -    items:
> -      - const: PD_IRQB
> -
>    connector:
>      type: object
>      $ref: ../connector/usb-connector.yaml#
> @@ -58,7 +54,6 @@ examples:
>          tcpc {
>            compatible = "mediatek,mt6360-tcpc";
>            interrupts-extended = <&gpio26 3 IRQ_TYPE_LEVEL_LOW>;
> -          interrupt-names = "PD_IRQB";
>  
>            connector {
>              compatible = "usb-c-connector";
> -- 
> 2.43.0
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)