linux-kernel - Re: [PATCH] mm, kmsan: fix infinite recursion due to RCU critical section

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a6f9a1fd-0ce2-b6be-6efe-181c54f950a0@quicinc.com>
Date: Fri, 19 Jan 2024 22:30:22 +0530
From: Charan Teja Kalla <quic_charante@...cinc.com>
To: Marco Elver <elver@...gle.com>
CC: Andrew Morton <akpm@...ux-foundation.org>,
        Alexander Potapenko
	<glider@...gle.com>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Thomas Gleixner
	<tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
        Borislav Petkov
	<bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>, <x86@...nel.org>,
        "H. Peter Anvin" <hpa@...or.com>, <kasan-dev@...glegroups.com>,
        <linux-kernel@...r.kernel.org>, <linux-mm@...ck.org>,
        <syzbot+93a9e8a3dea8d6085e12@...kaller.appspotmail.com>
Subject: Re: [PATCH] mm, kmsan: fix infinite recursion due to RCU critical
 section



On 1/18/2024 5:52 PM, Marco Elver wrote:
> It would be nice to avoid duplicating functions - both options have downsides:
> 1. Shared pfn_valid(): it might break for KMSAN again in future if new
> recursion is introduced.
> 2. KMSAN-version of pfn_valid(): it might break if pfn_valid() changes
> in future.
> 
> I suspect #1 is less likely.
> 
> What is your main concern by switching to rcu_read_lock_sched()?

No concerns from my side. Just wanted to know the thought behind
changing the pfn_valid instead of kmsan version, like for some
functions. Thanks for the clarification.