linux-kernel - Re: [PATCH 0/1] Support PERF_SAMPLE_READ with inherit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87a5p1kyif.fsf@linux.intel.com>
Date: Fri, 19 Jan 2024 09:45:44 -0800
From: Andi Kleen <ak@...ux.intel.com>
To: Ben Gainey <ben.gainey@....com>
Cc: linux-perf-users@...r.kernel.org,  linux-kernel@...r.kernel.org,
  peterz@...radead.org,  mingo@...hat.com,  acme@...nel.org,
  mark.rutland@....com,  alexander.shishkin@...ux.intel.com,
  jolsa@...nel.org,  namhyung@...nel.org,  irogers@...gle.com,
  adrian.hunter@...el.com,  james.clark@....com
Subject: Re: [PATCH 0/1] Support PERF_SAMPLE_READ with inherit_stat

Ben Gainey <ben.gainey@....com> writes:

> In this configuration stream ids (such as may appear in the read_format 
> field of a PERF_RECORD_SAMPLE) are no longer globally unique, rather 
> the pair of (stream id, tid) uniquely identify each event. Tools that 
> rely on this, for example to calculate a delta between samples, would 
> need updating to take this into account. Previously valid event 
> configurations (system-wide, no-inherit and so on) where each stream id 
> is the identifier are unaffected.

So is this an ABI break? It might need an optin, if it breaks anything,
which wouldn't surprise me. We do have a lot of different perf stream
parsers around these days and we cannot break them.

-Andi