linux-kernel - Re: [PATCH v1 18/26] crypto: ccp: Handle legacy SEV commands when SNP is enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240119174825.GAZaq16f0dlfle65To@fat_crate.local>
Date: Fri, 19 Jan 2024 18:48:25 +0100
From: Borislav Petkov <bp@...en8.de>
To: Tom Lendacky <thomas.lendacky@....com>
Cc: Michael Roth <michael.roth@....com>, x86@...nel.org,
	kvm@...r.kernel.org, linux-coco@...ts.linux.dev, linux-mm@...ck.org,
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
	tglx@...utronix.de, mingo@...hat.com, jroedel@...e.de,
	hpa@...or.com, ardb@...nel.org, pbonzini@...hat.com,
	seanjc@...gle.com, vkuznets@...hat.com, jmattson@...gle.com,
	luto@...nel.org, dave.hansen@...ux.intel.com, slp@...hat.com,
	pgonda@...gle.com, peterz@...radead.org,
	srinivas.pandruvada@...ux.intel.com, rientjes@...gle.com,
	tobin@....com, vbabka@...e.cz, kirill@...temov.name,
	ak@...ux.intel.com, tony.luck@...el.com,
	sathyanarayanan.kuppuswamy@...ux.intel.com, alpergun@...gle.com,
	jarkko@...nel.org, ashish.kalra@....com, nikunj.dadhania@....com,
	pankaj.gupta@....com, liam.merwick@...cle.com
Subject: Re: [PATCH v1 18/26] crypto: ccp: Handle legacy SEV commands when
 SNP is enabled

On Fri, Jan 19, 2024 at 11:36:44AM -0600, Tom Lendacky wrote:
> Using %#x will produce the 0x in the output (except if the value is zero for
> some reason).

printf-compatibility:

       #      The value should be converted to an "alternate form".  For o conversions,
              the first character of the output string is made zero (by prefixing  a  0
              if  it  was not zero already).  For x and X conversions, a nonzero result
              has the string "0x" (or "0X" for X conversions) prepended to it.

> So I would say make that 0x%x.

Yap, better, unambiguous.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette