linux-kernel - Re: [PATCH -fixes v2] RISC-V: KVM: Require HAVE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK9=C2X4R+3F5Lh-f33dPVMkyGt+koXorfwMOmB-JnqSs79eQw@mail.gmail.com>
Date: Fri, 19 Jan 2024 08:42:53 +0530
From: Anup Patel <apatel@...tanamicro.com>
To: Sean Christopherson <seanjc@...gle.com>
Cc: Anup Patel <anup@...infault.org>, Andrew Jones <ajones@...tanamicro.com>, 
	linux-riscv@...ts.infradead.org, linux-next@...r.kernel.org, 
	linux-kernel@...r.kernel.org, kvm@...r.kernel.org, 
	kvm-riscv@...ts.infradead.org, paul.walmsley@...ive.com, palmer@...belt.com, 
	aou@...s.berkeley.edu, atishp@...shpatra.org, rdunlap@...radead.org, 
	sfr@...b.auug.org.au, alex@...ti.fr, mpe@...erman.id.au, npiggin@...il.com, 
	linuxppc-dev@...ts.ozlabs.org, pbonzini@...hat.com
Subject: Re: [PATCH -fixes v2] RISC-V: KVM: Require HAVE_KVM

On Thu, Jan 18, 2024 at 11:10 PM Sean Christopherson <seanjc@...glecom> wrote:
>
> On Thu, Jan 18, 2024, Anup Patel wrote:
> > On Thu, Jan 4, 2024 at 6:07 PM Andrew Jones <ajones@...tanamicro.com> wrote:
> > >
> > > KVM requires EVENTFD, which is selected by HAVE_KVM. Other KVM
> > > supporting architectures select HAVE_KVM and then their KVM
> > > Kconfigs ensure its there with a depends on HAVE_KVM. Make RISCV
> > > consistent with that approach which fixes configs which have KVM
> > > but not EVENTFD, as was discovered with a randconfig test.
> > >
> > > Fixes: 99cdc6c18c2d ("RISC-V: Add initial skeletal KVM support")
> > > Reported-by: Randy Dunlap <rdunlap@...radead.org>
> > > Closes: https://lore.kernel.org/all/44907c6b-c5bd-4e4a-a921-e4d3825539d8@infradead.org/
> > > Signed-off-by: Andrew Jones <ajones@...tanamicro.com>
> >
> > Queued this patch for Linux-6.8
>
> That should be unnecessary.  Commit caadf876bb74 ("KVM: introduce CONFIG_KVM_COMMON"),
> which is in Paolo's pull request for 6.8, addresses the EVENTFD issue.  And the
> rest of Paolo's series[*], which presumably will get queued for 6.9, eliminates
> HAVE_KVM entirely.
>
> [*] https://lore.kernel.org/all/20240108124740.114453-6-pbonzini@redhat.com

I was not sure about the timeline of when Paolo's series would be merged
hence thought of taking this patch as a fix.

For now, I will drop this patch from my queue. If required we can have it
as a 6.8-rc fix.

Regards,
Anup