linux-kernel - [PATCH] proc: remove unnecessary comment since removal of no

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20240119033004.52937-1-qiansuyao@gmail.com>
Date: Fri, 19 Jan 2024 03:30:04 +0000
From: Suyao Qian <qiansuyao@...il.com>
To: linux-fsdevel@...r.kernel.org
Cc: linux-kernel@...r.kernel.org,
	Al Viro <viro@...iv.linux.org.uk>,
	Suyao Qian <qiansuyao@...il.com>
Subject: [PATCH] proc: remove unnecessary comment since removal of no_llseek

proc_lseek of NULL is checked during proc_reg_open(). Hence no longer
mandatory.

Fixes: 3f61631d47f1 ("take care to handle NULL ->proc_lseek()")
Signed-off-by: Suyao Qian <qiansuyao@...il.com>
---
 include/linux/proc_fs.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/linux/proc_fs.h b/include/linux/proc_fs.h
index de407e7c3b55..7ad73ed0cb8a 100644
--- a/include/linux/proc_fs.h
+++ b/include/linux/proc_fs.h
@@ -32,7 +32,6 @@ struct proc_ops {
 	ssize_t	(*proc_read)(struct file *, char __user *, size_t, loff_t *);
 	ssize_t (*proc_read_iter)(struct kiocb *, struct iov_iter *);
 	ssize_t	(*proc_write)(struct file *, const char __user *, size_t, loff_t *);
-	/* mandatory unless nonseekable_open() or equivalent is used */
 	loff_t	(*proc_lseek)(struct file *, loff_t, int);
 	int	(*proc_release)(struct inode *, struct file *);
 	__poll_t (*proc_poll)(struct file *, struct poll_table_struct *);
-- 
2.43.0