linux-kernel - Re: [PATCH 2/2] usb: dwc3: Add workaround for host mode VBUS glitch when boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240120005552.pxlofaaoovxjt2oj@synopsys.com>
Date: Sat, 20 Jan 2024 00:55:54 +0000
From: Thinh Nguyen <Thinh.Nguyen@...opsys.com>
To: Frank Li <Frank.Li@....com>
CC: "ran.wang_1@....com" <ran.wang_1@....com>,
        Greg Kroah-Hartman
	<gregkh@...uxfoundation.org>,
        "open list:DESIGNWARE USB3 DRD IP DRIVER"
	<linux-usb@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        "balbi@...nel.org" <balbi@...nel.org>,
        "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "pku.leo@...il.com" <pku.leo@...il.com>,
        "robh+dt@...nel.org"
	<robh+dt@...nel.org>,
        "sergei.shtylyov@...entembedded.com"
	<sergei.shtylyov@...entembedded.com>
Subject: Re: [PATCH 2/2] usb: dwc3: Add workaround for host mode VBUS glitch
 when boot

On Sat, Jan 20, 2024, Thinh Nguyen wrote:
> > +
> >  static int dwc3_host_get_irq(struct dwc3 *dwc)
> >  {
> >  	struct platform_device	*dwc3_pdev = to_platform_device(dwc->dev);
> > @@ -66,6 +105,13 @@ int dwc3_host_init(struct dwc3 *dwc)
> >  	int			ret, irq;
> >  	int			prop_idx = 0;
> >  
> > +	/*
> > +	 * We have to power off all Root hub ports immediately after DWC3 set
> > +	 * to host mode to avoid VBUS glitch happen when xhci get reset later.
> > +	 */
> > +	if (dwc->host_vbus_glitches)
> > +		dwc3_power_off_all_roothub_ports(dwc);
> > +
> 
> It's part of the dwc3_host_init(), but don't do this in
> dwc3_host_get_irq(). Place it where it makes sense.

Ignore this comment, I thought it's called from dwc3_host_get_irq(), but
it's not.

BR,
Thinh

> 
> >  	irq = dwc3_host_get_irq(dwc);
> >  	if (irq < 0)
> >  		return irq;
> > -- 
> > 2.34.1
> > 
>