lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240120-heult-applaudieren-d6449392b497@brauner>
Date: Sat, 20 Jan 2024 16:21:08 +0100
From: Christian Brauner <brauner@...nel.org>
To: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@...onical.com>
Cc: mszeredi@...hat.com, stgraber@...raber.org, 
	linux-fsdevel@...r.kernel.org, Seth Forshee <sforshee@...nel.org>, 
	Miklos Szeredi <miklos@...redi.hu>, Amir Goldstein <amir73il@...il.com>, 
	Bernd Schubert <bschubert@....com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 4/9] fs/fuse: support idmapped getattr inode op

>  int fuse_update_attributes(struct inode *inode, struct file *file, u32 mask)
>  {
> -	return fuse_update_get_attr(inode, file, NULL, mask, 0);
> +	return fuse_update_get_attr(&nop_mnt_idmap, inode, file, NULL, mask, 0);
>  }
>  
>  int fuse_reverse_inval_entry(struct fuse_conn *fc, u64 parent_nodeid,
> @@ -1506,7 +1510,7 @@ static int fuse_perm_getattr(struct inode *inode, int mask)
>  		return -ECHILD;
>  
>  	forget_all_cached_acls(inode);
> -	return fuse_do_getattr(inode, NULL, NULL);
> +	return fuse_do_getattr(&nop_mnt_idmap, inode, NULL, NULL);
>  }
>  
>  /*
> @@ -2062,7 +2066,7 @@ static int fuse_setattr(struct mnt_idmap *idmap, struct dentry *entry,
>  			 * ia_mode calculation may have used stale i_mode.
>  			 * Refresh and recalculate.
>  			 */
> -			ret = fuse_do_getattr(inode, NULL, file);
> +			ret = fuse_do_getattr(&nop_mnt_idmap, inode, NULL, file);
>  			if (ret)
>  				return ret;

These are internal getattr requests that don't originate from a specific mount?
Can you please add a comment about this in the commit message so it's
clear why it's ok to not pass the idmapping?

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ