linux-kernel - Re: [PATCH v2] iouring:added boundary value check for io_uring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f48e47b5-0572-4f84-b165-5a9e91788c57@kernel.dk>
Date: Sat, 20 Jan 2024 10:01:51 -0700
From: Jens Axboe <axboe@...nel.dk>
To: Subramanya Swamy <subramanya.swamy.linux@...il.com>, corbet@....net,
 jmoyer@...hat.com, asml.silence@...il.com, akpm@...ux-foundation.org,
 bhe@...hat.com, ribalda@...omium.org, rostedt@...dmis.org,
 sshegde@...ux.vnet.ibm.com, alexghiti@...osinc.com, matteorizzo@...gle.com,
 ardb@...nel.org, linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 io-uring@...r.kernel.org
Subject: Re: [PATCH v2] iouring:added boundary value check for io_uring_group
 systl

On 1/20/24 7:44 AM, Subramanya Swamy wrote:
> /proc/sys/kernel/io_uring_group takes gid as input
> added boundary value check to accept gid in range of
> 0<=gid<=4294967294 & Documentation is updated for same

This should have:

Fixes: 76d3ccecfa18 ("io_uring: add a sysctl to disable io_uring system-wide")

> diff --git a/Documentation/admin-guide/sysctl/kernel.rst b/Documentation/admin-guide/sysctl/kernel.rst
> index 6584a1f9bfe3..a8b61ab3e118 100644
> --- a/Documentation/admin-guide/sysctl/kernel.rst
> +++ b/Documentation/admin-guide/sysctl/kernel.rst
> @@ -470,10 +470,8 @@ io_uring_group
>  ==============
>  
>  When io_uring_disabled is set to 1, a process must either be
> -privileged (CAP_SYS_ADMIN) or be in the io_uring_group group in order
> -to create an io_uring instance.  If io_uring_group is set to -1 (the
> -default), only processes with the CAP_SYS_ADMIN capability may create
> -io_uring instances.
> +privledged (CAP_SYS_ADMIN) or be in the io_uring_group group in order

privileged.

-- 
Jens Axboe