linux-kernel - Re: [PATCH] iio: adc: ad7091r8: Fix error code in ad7091r8_gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Sun, 21 Jan 2024 16:59:14 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Marcelo Schmitt <marcelo.schmitt1@...il.com>
Cc: Dan Carpenter <dan.carpenter@...aro.org>, Marcelo Schmitt
 <marcelo.schmitt@...log.com>, Lars-Peter Clausen <lars@...afoo.de>, Michael
 Hennerich <Michael.Hennerich@...log.com>, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] iio: adc: ad7091r8: Fix error code in
 ad7091r8_gpio_setup()

On Thu, 11 Jan 2024 23:00:22 -0300
Marcelo Schmitt <marcelo.schmitt1@...il.com> wrote:

> On 01/08, Dan Carpenter wrote:
> > There is a copy and paste error so it accidentally returns ->convst_gpio
> > instead of ->reset_gpio.  Fix it.
> > 
> > Fixes: 0b76ff46c463 ("iio: adc: Add support for AD7091R-8")
> > Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> > ---  
> 
> Oops, that also slipped through.
> Thanks for the fix.
> 
> Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@...il.com>
Applied to the fixes-togreg branch of iio.git.

Thanks,

Jonathan

> 
> >  drivers/iio/adc/ad7091r8.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/iio/adc/ad7091r8.c b/drivers/iio/adc/ad7091r8.c
> > index 57700f124803..700564305057 100644
> > --- a/drivers/iio/adc/ad7091r8.c
> > +++ b/drivers/iio/adc/ad7091r8.c
> > @@ -195,7 +195,7 @@ static int ad7091r8_gpio_setup(struct ad7091r_state *st)
> >  	st->reset_gpio = devm_gpiod_get_optional(st->dev, "reset",
> >  						 GPIOD_OUT_HIGH);
> >  	if (IS_ERR(st->reset_gpio))
> > -		return dev_err_probe(st->dev, PTR_ERR(st->convst_gpio),
> > +		return dev_err_probe(st->dev, PTR_ERR(st->reset_gpio),
> >  				     "Error on requesting reset GPIO\n");
> >  
> >  	if (st->reset_gpio) {
> > -- 
> > 2.42.0
> > 
> >