linux-kernel - Re: [PATCH 2/2] ARM: decompressor: add option to ignore MEM ATAGs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbr3MqKNEM_AudEnknJOf6VaV7mBQre2puH_HLGWZYn8g@mail.gmail.com>
Date: Sun, 21 Jan 2024 20:37:19 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: Christian Marangi <ansuelsmth@...il.com>
Cc: Russell King <linux@...linux.org.uk>, Arnd Bergmann <arnd@...db.de>, 
	Andrew Morton <akpm@...ux-foundation.org>, Geert Uytterhoeven <geert+renesas@...der.be>, 
	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>, Jonathan Corbet <corbet@....net>, 
	Thomas Gleixner <tglx@...utronix.de>, Randy Dunlap <rdunlap@...radead.org>, 
	"Mike Rapoport (IBM)" <rppt@...nel.org>, Eric DeVolder <eric.devolder@...cle.com>, 
	Nathan Chancellor <nathan@...nel.org>, "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>, 
	Kees Cook <keescook@...omium.org>, linux-arm-kernel@...ts.infradead.org, 
	linux-kernel@...r.kernel.org, Bjorn Andersson <andersson@...nel.org>, 
	Konrad Dybcio <konrad.dybcio@...ainline.org>, John Crispin <john@...ozen.org>
Subject: Re: [PATCH 2/2] ARM: decompressor: add option to ignore MEM ATAGs

On Sat, Jan 20, 2024 at 6:00 PM Christian Marangi <ansuelsmth@...ilcom> wrote:
> On Sat, Jan 20, 2024 at 12:52:33PM +0100, Linus Walleij wrote:
> > On Fri, Jan 19, 2024 at 9:14 PM Christian Marangi <ansuelsmth@...il.com> wrote:
> >
> > > +#if defined(CONFIG_ARM_ATAG_DTB_COMPAT_IGNORE_MEM)
> > > +#define do_ignore_mem 1
> > > +#else
> > > +#define do_ignore_mem 0
> > > +#endif
> >
> > Is there a reason why you can't just use:
> >
> > if (IS_ENABLED(CONFIG_ARM_ATAG_DTB_COMPAT_IGNORE_MEM))
> > in the code?
> >
>
> Was following the pattern, yes I can totally do this change... Will send
> a v2 with this changed.
>
> Since the first patch has to be regression tested, is it ok to add the
> Tag in v2 or I should wait that to send v2?

Just add the tag.

Thanks,
Linus Walleij