linux-kernel - Re: [PATCH] spi: s3c64xx: Extract FIFO depth calculation to a dedicated macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 21 Jan 2024 21:23:54 +0100
From: Andi Shyti <andi.shyti@...nel.org>
To: Sam Protsenko <semen.protsenko@...aro.org>
Cc: Mark Brown <broonie@...nel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Alim Akhtar <alim.akhtar@...sung.com>, linux-spi@...r.kernel.org, 
	linux-samsung-soc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: s3c64xx: Extract FIFO depth calculation to a
 dedicated macro

Hi Sam,

>  	void __iomem *regs = sdd->regs;
>  	unsigned long val = 1;
>  	u32 status;
> -
> -	/* max fifo depth available */
> -	u32 max_fifo = (FIFO_LVL_MASK(sdd) >> 1) + 1;
> +	u32 max_fifo = FIFO_DEPTH(sdd);

Why have you removed the comment? Perhaps you could place it on
the side in order to remove that awful space.

Not a biding comment, though:

Reviewed-by: Andi Shyti <andi.shyti@...nel.org>

Andi