linux-kernel - Re: [PATCH RESEND v2] dt-bindings: input: touchscreen: goodix: clarify irq-gpios misleading text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zayl9KC53pFWk5_Q@google.com>
Date: Sat, 20 Jan 2024 21:04:52 -0800
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: Luca Ceresoli <luca.ceresoli@...tlin.com>
Cc: devicetree@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
	Jeff LaBundy <jeff@...undy.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
	Rob Herring <robh@...nel.org>
Subject: Re: [PATCH RESEND v2] dt-bindings: input: touchscreen: goodix:
 clarify irq-gpios misleading text

On Tue, Jan 02, 2024 at 09:19:34AM +0100, Luca Ceresoli wrote:
> The irq-gpios description misleading, apparently saying that driving the
> IRQ GPIO resets the device, which is even more puzzling as there is a reset
> GPIO as well.
> 
> In reality the IRQ pin can be driven during the reset sequence to configure
> the client address, as it becomes clear after checking both the datasheet
> and the driver code. Improve the text to clarify that.
> 
> Also rephrase to remove reference to the driver, which is not appropriate
> in the bindings.
> 
> Signed-off-by: Luca Ceresoli <luca.ceresoli@...tlin.com>
> Acked-by: Rob Herring <robh@...nel.org>
> Reviewed-by: Jeff LaBundy <jeff@...undy.com>

Applied, thank you.

-- 
Dmitry