linux-kernel - RE: [PATCH 1/2] x86: Remove dynamic NOP selection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c911eadd249d4e4cbc8c247ed677b56a@AcuMS.aculab.com>
Date: Sun, 21 Jan 2024 22:36:32 +0000
From: David Laight <David.Laight@...LAB.COM>
To: 'Linus Torvalds' <torvalds@...uxfoundation.org>, "H. Peter Anvin"
	<hpa@...or.com>
CC: Thorsten Glaser <tg@...ian.org>, Peter Zijlstra <peterz@...radead.org>,
	"x86@...nel.org" <x86@...nel.org>, "rostedt@...dmis.org"
	<rostedt@...dmis.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-toolchains@...r.kernel.org"
	<linux-toolchains@...r.kernel.org>, "jpoimboe@...hat.com"
	<jpoimboe@...hat.com>, "alexei.starovoitov@...il.com"
	<alexei.starovoitov@...il.com>, "mhiramat@...nel.org" <mhiramat@...nel.org>
Subject: RE: [PATCH 1/2] x86: Remove dynamic NOP selection

From: Linus Torvalds
> Sent: 20 January 2024 17:00
...
> And if I add "-r" to get relocation info, I get
> 
>         call   <delayed_put_task_struct+0x1a>
>                         R_X86_64_PLT32  rethook_flush_task-0x4
> 
> which shows the raw relocation data, but with truly mind-bogglingly
> horrendous syntax.
> 
> Is there some sane tool that just does the sane thing and shows this as
> 
>         call   rethook_flush_task
> 
> which is what the thing actually means?

While you are re-writing a disassembler, remember to print the
contents of string when you get a reference into .rodata.str :-)

How many times have you had to dig out a printf format string in
order to locate the source associated with some object code?
It is so much easier if the disassembler does it for you.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)