linux-kernel - Re: [PATCH] video: fbdev: sis: Error out if pixclock equals zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fb18e94f-3254-48d1-b260-1c3a7514bd8f@gmx.de>
Date: Sun, 21 Jan 2024 09:01:55 +0100
From: Helge Deller <deller@....de>
To: Fullway Wang <fullwaywang@...look.com>, tzimmermann@...e.de,
 sam@...nborg.org, javierm@...hat.com
Cc: linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 fullwaywang@...cent.com
Subject: Re: [PATCH] video: fbdev: sis: Error out if pixclock equals zero

On 1/18/24 07:24, Fullway Wang wrote:
> The userspace program could pass any values to the driver through
> ioctl() interface. If the driver doesn't check the value of pixclock,
> it may cause divide-by-zero error.
>
> In sisfb_check_var(), var->pixclock is used as a divisor to caculate
> drate before it is checked against zero. Fix this by checking it
> at the beginning.
>
> This is similar to CVE-2022-3061 in i740fb which was fixed by
> commit 15cf0b8.
>
> Signed-off-by: Fullway Wang <fullwaywang@...look.com>
> ---
>   drivers/video/fbdev/sis/sis_main.c | 2 ++
>   1 file changed, 2 insertions(+)

I've applied this patch and your savage patch to fbdev git tree.

Thanks!
Helge