linux-kernel - Re: [PATCH v11 03/10] spi: Add multi-cs memories support in SPI core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4c69cb61-1a43-4bfe-b01a-8118967ddbaf@leemhuis.info>
Date: Sun, 21 Jan 2024 10:42:32 +0100
From: "Linux regression tracking #adding (Thorsten Leemhuis)"
 <regressions@...mhuis.info>
To: Guenter Roeck <linux@...ck-us.net>,
 Amit Kumar Mahapatra <amit.kumar-mahapatra@....com>
Cc: alexandre.belloni@...tlin.com, vigneshr@...com,
 alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
 linux-mtd@...ts.infradead.org, miquel.raynal@...tlin.com, git@....com,
 sbinding@...nsource.cirrus.com, richard@....at, lee@...nel.org,
 tudor.ambarus@...aro.org, amitrkcian2002@...il.com,
 linux-sound@...r.kernel.org, james.schulman@...rus.com,
 rf@...nsource.cirrus.com, broonie@...nel.org, tiwai@...e.com,
 perex@...ex.cz, michal.simek@....com, linux-arm-kernel@...ts.infradead.org,
 patches@...nsource.cirrus.com, claudiu.beznea@...on.dev,
 linux-spi@...r.kernel.org, michael@...le.cc, david.rhodes@...rus.com,
 pratyush@...nel.org
Subject: Re: [PATCH v11 03/10] spi: Add multi-cs memories support in SPI core

On 12.01.24 20:11, Guenter Roeck wrote:
> 
> On Sat, Nov 25, 2023 at 02:51:30PM +0530, Amit Kumar Mahapatra wrote:
>> AMD-Xilinx GQSPI controller has two advanced mode that allows the
>> controller to consider two flashes as one single device.
>>
>> One of these two mode is the parallel mode in which each byte of data is
>> stored in both devices, the even bits in the lower flash & the odd bits in
>> the upper flash. The byte split is automatically handled by the QSPI
>> controller.
> [...]
> With this patch in the mainline kernel, two of my qemu emulations
> (quanta-q71l-bmc and almetto-bmc) fail to instantiate the first SPI
> controller and thus fail to boot from SPI. The error message is
> 
> [    3.006458] spi_master spi0: No. of CS is more than max. no. of supported CS
> [    3.006775] spi_master spi0: Failed to create SPI device for /ahb/spi@...20000/flash@0
> 
> The problem is no longer seen after reverting this patch.
> [...]
> # first bad commit: [4d8ff6b0991d5e86b17b235fc46ec62e9195cb9b] spi: Add multi-cs memories support in SPI core

Thanks for the report. To be sure the issue doesn't fall through the
cracks unnoticed, I'm adding it to regzbot, the Linux kernel regression
tracking bot:

#regzbot ^introduced 4d8ff6b0991d5e86b17b235fc46ec62e9195cb9
#regzbot title spi: qemu emulations quanta-q71l-bmc and almetto-bmc fail
to boot
#regzbot ignore-activity

This isn't a regression? This issue or a fix for it are already
discussed somewhere else? It was fixed already? You want to clarify when
the regression started to happen? Or point out I got the title or
something else totally wrong? Then just reply and tell me -- ideally
while also telling regzbot about it, as explained by the page listed in
the footer of this mail.

Developers: When fixing the issue, remember to add 'Link:' tags pointing
to the report (the parent of this mail). See page linked in footer for
details.

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
That page also explains what to do if mails like this annoy you.