linux-kernel - Re: [cocci] [v2] coccinelle: device_attr_show: Adapt to the latest Documentation/filesystems/sysfs.rst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f34231dc-186b-4cb9-889b-b3be9224c5a9@web.de>
Date: Sun, 21 Jan 2024 11:40:41 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Li Zhijian <lizhijian@...itsu.com>, Julia Lawall <julia.lawall@...ia.fr>,
 cocci@...ia.fr
Cc: LKML <linux-kernel@...r.kernel.org>, Nicolas Palix <nicolas.palix@...g.fr>
Subject: Re: [cocci] [v2] coccinelle: device_attr_show: Adapt to the latest
 Documentation/filesystems/sysfs.rst

> I subsequently simplified the patch case to contain the following:
>
> -              snprintf(BUF, SZ, FORMAT
> +              sysfs_emit(BUF, FORMAT
>                                ,...);
>
> This also works for the case where there are only three arguments.
> It has the benefit that the change is recognized as a line replacement, so
> no extra {} are added when the call is in an if branch.

Would you like to consider the application of the following SmPL code variant?

-snprintf
+sysfs_emit
         (BUF,
-         SZ,
          FORMAT,
          ...
         );

Regards,
Markus