linux-kernel - Re: [PATCH] maple_tree: avoid duplicate variable init in mast_spanning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 22 Jan 2024 09:58:16 -0500
From: "Liam R. Howlett" <Liam.Howlett@...cle.com>
To: Lukas Bulwahn <lukas.bulwahn@...il.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>, maple-tree@...ts.infradead.org,
        linux-mm@...ck.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] maple_tree: avoid duplicate variable init in
 mast_spanning_rebalance()

* Lukas Bulwahn <lukas.bulwahn@...il.com> [240122 05:22]:
> The local variables r_tmp and l_tmp in mast_spanning_rebalance() are
> already initialized at its declaration; there is no need to assign the
> value again.
> 
> Remove the duplicate initialization of {r,l}_tmp. No functional change.
> Due to common compiler optimizations, also no change to object code.

Hello!

Thanks for this patch and well stated change log.

> 
> This issue was identified with clang-analyzer's dead stores analysis.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>

Reviewed-by: Liam R. Howlett <Liam.Howlett@...cle.com>

> ---
>  lib/maple_tree.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> index 7b161802860b..82fb5195c235 100644
> --- a/lib/maple_tree.c
> +++ b/lib/maple_tree.c
> @@ -2271,8 +2271,6 @@ bool mast_spanning_rebalance(struct maple_subtree_state *mast)
>  	struct ma_state l_tmp = *mast->orig_l;
>  	unsigned char depth = 0;
>  
> -	r_tmp = *mast->orig_r;
> -	l_tmp = *mast->orig_l;
>  	do {
>  		mas_ascend(mast->orig_r);
>  		mas_ascend(mast->orig_l);
> -- 
> 2.17.1
>