linux-kernel - Re: [PATCH] keys, dns: Fix size check of V1 server-list header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 22 Jan 2024 07:02:32 -0800
From: Greg KH <gregkh@...uxfoundation.org>
To: sedat.dilek@...il.com
Cc: David Howells <dhowells@...hat.com>, ceph-devel@...r.kernel.org,
	davem@...emloft.net, eadavis@...com, edumazet@...gle.com,
	horms@...nel.org, jaltman@...istor.com, jarkko@...nel.org,
	jlayton@...hat.com, keyrings@...r.kernel.org, kuba@...nel.org,
	linux-afs@...ts.infradead.org, linux-cifs@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-nfs@...r.kernel.org, marc.dionne@...istor.com,
	markus.suvanto@...il.com, netdev@...r.kernel.org, pabeni@...hat.com,
	pengfei.xu@...el.com, smfrench@...il.com, stable@...r.kernel.org,
	torvalds@...ux-foundation.org, wang840925@...il.com,
	sashal@...nel.org, pvorel@...e.cz
Subject: Re: [PATCH] keys, dns: Fix size check of V1 server-list header

On Mon, Jan 22, 2024 at 08:32:20AM +0100, Petr Vorel wrote:
> From: Sedat Dilek <sedat.dilek@...il.com>
> 
> On Wed, Jan 10, 2024 at 10:12 PM David Howells <dhowells@...hat.com> wrote:
> >
> >
> > Fix the size check added to dns_resolver_preparse() for the V1 server-list
> > header so that it doesn't give EINVAL if the size supplied is the same as
> > the size of the header struct (which should be valid).
> >
> > This can be tested with:
> >
> >         echo -n -e '\0\0\01\xff\0\0' | keyctl padd dns_resolver desc @p
> >
> > which will give "add_key: Invalid argument" without this fix.
> >
> > Fixes: 1997b3cb4217 ("keys, dns: Fix missing size check of V1 server-list header")
> 
> [ CC stable@...r.kernel.org ]
> 
> Your (follow-up) patch is now upstream.
> 
> https://git.kernel.org/linus/acc657692aed438e9931438f8c923b2b107aebf9
> 
> This misses CC: Stable Tag as suggested by Linus.
> 
> Looks like linux-6.1.y and linux-6.6.y needs it, too.
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v6.6.11&id=da89365158f6f656b28bcdbcbbe9eaf97c63c474
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v6.1.72&id=079eefaecfd7bbb8fcc30eccb0dfdf50c91f1805

And 5.10.y and 5.15.y.  Now queued up, thanks.

greg k-h