linux-kernel - Re: [PATCH v3 2/3] watchdog: Add ChromeOS EC-based watchdog driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 22 Jan 2024 16:09:32 +0100
From: Łukasz Majczak <lma@...omium.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Gwendal Grignou <gwendal@...omium.org>, Tzung-Bi Shih <tzungbi@...nel.org>, 
	Radoslaw Biernacki <biernacki@...gle.com>, Wim Van Sebroeck <wim@...ux-watchdog.org>, 
	Lee Jones <lee@...nel.org>, Benson Leung <bleung@...omium.org>, 
	Guenter Roeck <groeck@...omium.org>, linux-watchdog@...r.kernel.org, 
	linux-kernel@...r.kernel.org, chrome-platform@...ts.linux.dev
Subject: Re: [PATCH v3 2/3] watchdog: Add ChromeOS EC-based watchdog driver

On Mon, Jan 22, 2024 at 11:31 AM Krzysztof Kozlowski <krzk@...nel.org> wrote:
> > +     wdd = devm_kzalloc(&pdev->dev, sizeof(struct watchdog_device), GFP_KERNEL);
>
> sizeof(*)
>
ACK.

> > +MODULE_DEVICE_TABLE(platform, cros_ec_wdt_id);
>
> device_id is not placed here, please open existing drivers for
> reference. Why this isn't referenced in driver structure?
>
ACK, I will take s3c2410_wdt.c as an example, thank you.

Best regards,
Lukasz