linux-kernel - Re: [PATCH] pmdomain: core: Move the unused cleanup to a

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 22 Jan 2024 16:21:46 +0100
From: Ulf Hansson <ulf.hansson@...aro.org>
To: Konrad Dybcio <konrad.dybcio@...aro.org>
Cc: Kevin Hilman <khilman@...aro.org>, "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>, 
	Marijn Suijten <marijn.suijten@...ainline.org>, linux-pm@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Bjorn Andersson <andersson@...nel.org>
Subject: Re: [PATCH] pmdomain: core: Move the unused cleanup to a _sync initcall

On Wed, 27 Dec 2023 at 16:21, Konrad Dybcio <konrad.dybcio@...aro.org> wrote:
>
> The unused clock cleanup uses the _sync initcall to give all users at
> earlier initcalls time to probe. Do the same to avoid leaving some PDs
> dangling at "on" (which actually happened on qcom!).
>
> Fixes: 2fe71dcdfd10 ("PM / domains: Add late_initcall to disable unused PM domains")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Applied for fixes and by adding a stable tag, thanks!

Kind regards
Uffe



> ---
>  drivers/pmdomain/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pmdomain/core.c b/drivers/pmdomain/core.c
> index a1f6cba3ae6c..18e232b5ed53 100644
> --- a/drivers/pmdomain/core.c
> +++ b/drivers/pmdomain/core.c
> @@ -1109,7 +1109,7 @@ static int __init genpd_power_off_unused(void)
>
>         return 0;
>  }
> -late_initcall(genpd_power_off_unused);
> +late_initcall_sync(genpd_power_off_unused);
>
>  #ifdef CONFIG_PM_SLEEP
>
>
> ---
> base-commit: 39676dfe52331dba909c617f213fdb21015c8d10
> change-id: 20231227-topic-pmdomain_sync_cleanup-ae73d04133ec
>
> Best regards,
> --
> Konrad Dybcio <konrad.dybcio@...aro.org>
>