linux-kernel - Re: [PATCH] pmdomain: Add a null pointer check to the omap_prm_domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFp=s7aOnpXti=rGTri=exW7sHdH693TEz7cQTiv=2gnFw@mail.gmail.com>
Date: Mon, 22 Jan 2024 16:21:52 +0100
From: Ulf Hansson <ulf.hansson@...aro.org>
To: Kunwu Chan <chentao@...inos.cn>
Cc: nm@...com, ssantosh@...nel.org, linux-kernel@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH] pmdomain: Add a null pointer check to the omap_prm_domain_init

On Thu, 18 Jan 2024 at 06:43, Kunwu Chan <chentao@...inos.cn> wrote:
>
> devm_kasprintf() returns a pointer to dynamically allocated memory
> which can be NULL upon failure. Ensure the allocation was successful
> by checking the pointer validity.
>
> Signed-off-by: Kunwu Chan <chentao@...inos.cn>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/pmdomain/ti/omap_prm.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pmdomain/ti/omap_prm.c b/drivers/pmdomain/ti/omap_prm.c
> index c2feae3a634c..b8ceb3c2b81c 100644
> --- a/drivers/pmdomain/ti/omap_prm.c
> +++ b/drivers/pmdomain/ti/omap_prm.c
> @@ -695,6 +695,8 @@ static int omap_prm_domain_init(struct device *dev, struct omap_prm *prm)
>         data = prm->data;
>         name = devm_kasprintf(dev, GFP_KERNEL, "prm_%s",
>                               data->name);
> +       if (!name)
> +               return -ENOMEM;
>
>         prmd->dev = dev;
>         prmd->prm = prm;
> --
> 2.39.2
>