linux-kernel - Re: [PATCH v3 11/20] drivers/gpu/drm/bridge/synopsys/dw-hdmi.c: remove I2C_CLASS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 22 Jan 2024 16:31:46 +0100
From: Robert Foss <rfoss@...nel.org>
To: Heiner Kallweit <hkallweit1@...il.com>
Cc: Wolfram Sang <wsa@...nel.org>, Andrzej Hajda <andrzej.hajda@...el.com>, 
	Maxime Ripard <mripard@...nel.org>, Neil Armstrong <neil.armstrong@...aro.org>, 
	Jonas Karlman <jonas@...boo.se>, dri-devel@...ts.freedesktop.org, 
	linux-kernel@...r.kernel.org, Jernej Skrabec <jernej.skrabec@...il.com>, 
	linux-i2c@...r.kernel.org, Thomas Zimmermann <tzimmermann@...e.de>, 
	Laurent Pinchart <Laurent.pinchart@...asonboard.com>
Subject: Re: [PATCH v3 11/20] drivers/gpu/drm/bridge/synopsys/dw-hdmi.c:
 remove I2C_CLASS_DDC support

On Sun, Nov 19, 2023 at 11:15 AM Heiner Kallweit <hkallweit1@...il.com> wrote:
>
> After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
> olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
> Class-based device auto-detection is a legacy mechanism and shouldn't
> be used in new code. So we can remove this class completely now.
>
> Preferably this series should be applied via the i2c tree.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
>
> ---
>  drivers/gpu/drm/bridge/synopsys/dw-hdmi.c |    1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> index 52d91a0df..aca5bb086 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> @@ -515,7 +515,6 @@ static struct i2c_adapter *dw_hdmi_i2c_adapter(struct dw_hdmi *hdmi)
>         init_completion(&i2c->cmp);
>
>         adap = &i2c->adap;
> -       adap->class = I2C_CLASS_DDC;
>         adap->owner = THIS_MODULE;
>         adap->dev.parent = hdmi->dev;
>         adap->algo = &dw_hdmi_algorithm;
>

Acked-by: Robert Foss <rfoss@...nel.org>