linux-kernel - Re: [PATCH 2/6] pwm: sprd: Improve the pwm backlight control function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4e3ee39f-2cad-4543-a505-8b0d16a01ad6@kernel.org>
Date: Mon, 22 Jan 2024 16:46:34 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Wenhua Lin <Wenhua.Lin@...soc.com>,
 Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc: Orson Zhai <orsonzhai@...il.com>,
 Baolin Wang <baolin.wang@...ux.alibaba.com>,
 Chunyan Zhang <zhang.lyra@...il.com>, linux-pwm@...r.kernel.org,
 linux-kernel@...r.kernel.org, wenhua lin <wenhua.lin1994@...il.com>,
 Xiongpeng Wu <xiongpeng.wu@...soc.com>, zhaochen su
 <zhaochen.su29@...il.com>, Zhaochen Su <Zhaochen.Su@...soc.com>,
 Xiaolong Wang <Xiaolong.Wang@...soc.com>
Subject: Re: [PATCH 2/6] pwm: sprd: Improve the pwm backlight control function

On 22/01/2024 09:17, Wenhua Lin wrote:
> +
>  static int sprd_pwm_probe(struct platform_device *pdev)
>  {
>  	struct sprd_pwm_chip *spc;
> @@ -288,6 +310,10 @@ static int sprd_pwm_probe(struct platform_device *pdev)
>  	if (ret)
>  		return ret;
>  
> +	ret = sprd_pwm_get_mod(pdev);
> +	if (ret)
> +		dev_err(&pdev->dev, "get pwm mod failed! Use default setting\n");

That's not an error. dev_info. Assuming that it will even stay (once you
send proper version for proper review).

Best regards,
Krzysztof