linux-kernel - Re: [PATCH 00/10] netfs, afs, cifs, cachefiles, erofs: Miscellaneous fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 22 Jan 2024 10:57:38 -0500
From: Jeff Layton <jlayton@...nel.org>
To: David Howells <dhowells@...hat.com>, Christian Brauner
	 <christian@...uner.io>
Cc: Matthew Wilcox <willy@...radead.org>, netfs@...ts.linux.dev, 
 linux-afs@...ts.infradead.org, linux-cifs@...r.kernel.org, 
 linux-nfs@...r.kernel.org, ceph-devel@...r.kernel.org,
 v9fs@...ts.linux.dev,  linux-erofs@...ts.ozlabs.org,
 linux-fsdevel@...r.kernel.org, linux-mm@...ck.org, 
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/10] netfs, afs, cifs, cachefiles, erofs:
 Miscellaneous fixes

On Mon, 2024-01-22 at 12:38 +0000, David Howells wrote:
> Hi Christian,
> 
> Here are some miscellaneous fixes for netfslib and a number of filesystems:
> 
>  (1) Replace folio_index() with folio->index in netfs, afs and cifs.
> 
>  (2) Fix an oops in fscache_put_cache().
> 
>  (3) Fix error handling in netfs_perform_write().
> 
>  (4) Fix an oops in cachefiles when not using erofs ondemand mode.
> 
>  (5) In afs, hide silly-rename files from getdents() to avoid problems with
>      tar and suchlike.
> 
>  (6) In afs, fix error handling in lookup with a bulk status fetch.
> 
>  (7) In afs, afs_dynroot_d_revalidate() is redundant, so remove it.
> 
>  (8) In afs, fix the RCU unlocking in afs_proc_addr_prefs_show().
> 
> The patches can also be found here:
> 
> 	https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=netfs-fixes
> 
> Thanks,
> David
> 
> Dan Carpenter (2):
>   netfs, fscache: Prevent Oops in fscache_put_cache()
>   netfs: Fix a NULL vs IS_ERR() check in netfs_perform_write()
> 
> David Howells (8):
>   netfs: Don't use certain internal folio_*() functions
>   afs: Don't use certain internal folio_*() functions
>   cifs: Don't use certain internal folio_*() functions
>   cachefiles, erofs: Fix NULL deref in when cachefiles is not doing
>     ondemand-mode
>   afs: Hide silly-rename files from userspace
>   afs: Fix error handling with lookup via FS.InlineBulkStatus
>   afs: Remove afs_dynroot_d_revalidate() as it is redundant
>   afs: Fix missing/incorrect unlocking of RCU read lock
> 
>  fs/afs/dir.c               | 30 ++++++++++++++++++++++--------
>  fs/afs/dynroot.c           |  9 ---------
>  fs/afs/proc.c              |  5 +++--
>  fs/cachefiles/namei.c      | 16 ++++++++++------
>  fs/netfs/buffered_read.c   | 12 ++++++------
>  fs/netfs/buffered_write.c  | 15 ++++++++-------
>  fs/netfs/fscache_cache.c   |  3 ++-
>  fs/netfs/io.c              |  2 +-
>  fs/netfs/misc.c            |  2 +-
>  fs/smb/client/file.c       | 10 +++++-----
>  include/trace/events/afs.h | 25 +++++++++++++++++++++++++
>  11 files changed, 83 insertions(+), 46 deletions(-)
> 

These all look fine to me. You can add this to the set:

Reviewed-by: Jeff Layton <jlayton@...nel.org>