linux-kernel - Re: [PATCH v2 2/3] dt-bindings: input: imagis: Document touch keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8366736.NyiUUSuA9g@radijator>
Date: Mon, 22 Jan 2024 17:25:05 +0100
From: Duje Mihanović <duje.mihanovic@...le.hr>
To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc: Markuss Broks <markuss.broks@...il.com>,
 Dmitry Torokhov <dmitry.torokhov@...il.com>,
 Rob Herring <robh+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 Karel Balej <balejk@...fyz.cz>, ~postmarketos/upstreaming@...ts.sr.ht,
 phone-devel@...r.kernel.org, devicetree@...r.kernel.org,
 linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/3] dt-bindings: input: imagis: Document touch keys

On Monday, January 22, 2024 11:27:09 AM CET Krzysztof Kozlowski wrote:
> On 20/01/2024 22:16, Duje Mihanović wrote:
> > diff --git
> > a/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml
> > b/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml
> > index 2af71cbcc97d..960e5436642f 100644
> > ---
> > a/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml
> > +++
> > b/Documentation/devicetree/bindings/input/touchscreen/
imagis,ist3038c.yaml> 
> > @@ -42,6 +42,17 @@ properties:
> >    touchscreen-inverted-y: true
> >    touchscreen-swapped-x-y: true
> > 
> > +if:
> Move allOf here and keep it under allOf.
> 
> > +  properties:
> > +    compatible:
> > +      contains:
> > +        const: imagis,ist3032c
> > +then:
> > +  properties:
> 
> > +    linux,keycodes:
> No, this property is not allowed by your binding. I doubt this was
> really tested.
> 
> Anyway, even if it works, it's not what we expect. Where is the property
> defined?

I was under the impression that it can be defined inside the if statement 
since "make dt_binding_check" ran without any errors. If that's wrong, I'm not 
sure how else to make the property valid only for ist3032c (the two devices 
using ist3038c, samsung-j5 and j5x seem to have tm2-touchkey instead).

Regards,
--
Duje