linux-kernel - RE: [PATCH v2] kbuild: resolve symlinks for O= properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6c9e46e44215461b83e9e351cd1c760a@AcuMS.aculab.com>
Date: Mon, 22 Jan 2024 16:45:31 +0000
From: David Laight <David.Laight@...LAB.COM>
To: 'Sebastian Andrzej Siewior' <bigeasy@...utronix.de>, Masahiro Yamada
	<masahiroy@...nel.org>
CC: "linux-kbuild@...r.kernel.org" <linux-kbuild@...r.kernel.org>, "Nicolas
 Schier" <n.schier@....de>, Nathan Chancellor <nathan@...nel.org>, "Nick
 Desaulniers" <ndesaulniers@...gle.com>, Nicolas Schier <nicolas@...sle.eu>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2] kbuild: resolve symlinks for O= properly

From: Sebastian Andrzej Siewior
> Sent: 22 January 2024 14:12
> 
> On 2023-12-16 01:06:37 [+0900], Masahiro Yamada wrote:
> …
> > Using the physical directory structure for the O= option seems more
> > reasonable.
> >
> > The comment says "expand a shell special character '~'", but it has
> > already been expanded to the home directory in the command line.
> 
> It might have been expanded, it might have not been expanded. Having a
> shell script:
> | #!/bin/sh
> |
> | exec make O=~/scratch/mk-check defconfig
> 
> with bin/sh = dash results in:
> 
> | make[1]: Entering directory '/home/bigeasy/linux/~/scratch/mk-check'
> 
> while bin/sh = bash expands the ~ properly before for O=. Would it be
> too much to ask, to expand the ~?

Raise a bug on dash...

Or split the lines:
O=~/xxxx
make O="$O" ...

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)